[CMake] Respect CMAKE_INSTALL_PREFIX at install time #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The standard way of cmake install to a destination folder is the following pattern: ```shell cd <BUILD_DIR> cmake <SRC_DIR> cmake --build <BUILD_DIR> cmake --install <BUILD_DIR> --prefix <INSTALL_DIR> ``` Right now, the `<INSTALL_DIR>` folder passed in cmake --install command is ignored, and always installed into `C:/Program Files(x86)/...`, which is the default `CMAKE_INSTALL_PREFIX` value passed at the `cmake <SRC_DIR>` call. Thus, it is not possible to install the binaries into different folders without rerun the cmake/build process. The important thing here is, the cmake variable `CMAKE_INSTALL_PREFIX` is supposed to be passed at `cmake --install` time with the `--prefix` argument. In cmake file, `install` with relative path will use that prefix automaticlly. And it is the best practice to not include CMAKE_INSTALL_PREFIX in the `install(... DESTINATION )` argument: ``` In particular, there is no need to make paths absolute by prepending CMAKE_INSTALL_PREFIX; this prefix is used by default if the DESTINATION is a relative path. ``` referenced from: https://cmake.org/cmake/help/latest/command/install.html
Collaborator
|
Thanks @ArcEarth ; and thanks for the explanation; I will merge this :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard way of cmake install to a destination folder is the following pattern:
Right now, the
<INSTALL_DIR>folder passed in cmake --install command is ignored,and always installed into
C:/Program Files(x86)/..., which is the defaultCMAKE_INSTALL_PREFIXvalue passed at thecmake <SRC_DIR>call.Thus, it is not possible to install the binaries into different folders
without rerun the cmake/build process.
The important thing here is, the cmake variable
CMAKE_INSTALL_PREFIXis supposed to be passed at
cmake --installtime with the--prefixargument.In cmake file,
installwith relative path will use that prefix automaticlly.And it is the best practice to not include CMAKE_INSTALL_PREFIX
in the
install(... DESTINATION )argument:referenced from: https://cmake.org/cmake/help/latest/command/install.html