Skip to content

Conversation

@dimbleby
Copy link
Member

This project currently fails to declare its dependencies on django and pytz; and in particular per #25 django 3.2 is not yet supported.

Make those dependencies explicit.

In particular, django<3.2 until that release is supported
@dimbleby
Copy link
Member Author

I don't have permission to view details of the failed pipelines: so if they're somehow my fault and you'd like me to do something about that, you'll have to tell me.

@absci
Copy link
Contributor

absci commented Apr 13, 2021

Hi, I don't think the pipeline failure is related to your pull request, I have re-runed it.

@absci absci merged commit f2d27ee into microsoft:dev Apr 16, 2021
@dimbleby
Copy link
Member Author

@absci I see you tweaked this to say <=3.2. Obviously I'm happy that 3.2 support is coming!

However, this constraint will prevent patch upgrades ie users won't be able to take Django 3.2.1, 3.2.2 etc. Was that your intention? It looks as though typically Django bumps of this type have not required changes in the backend, it is minor bumps (ie 3.0 -> 3.1, 3.1->3.2) that have needed changes.

Suggest that <3.3 is probably a better choice?

@absci
Copy link
Contributor

absci commented Apr 19, 2021

@dimbleby I think you're right, I'll make the change, thanks for your suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants