-
Notifications
You must be signed in to change notification settings - Fork 27
FEAT: Pipeline & Setup to Build WHL Files and Python Backward Compatibility #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bewithgaurav/build_whl_pipeline
sumitmsft
approved these changes
May 15, 2025
Contributor
sumitmsft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Support for x64 and ARM64 to build WHL file and python version backward compatibility (>=3.10) for wider adaptability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant updates to the build pipeline, Python bindings, and supporting documentation for the
mssql_pythonproject. The changes streamline the build process, enhance compatibility with multiple Python versions and architectures, and improve the maintainability of the codebase. Below are the key updates:Build Pipeline Enhancements
eng/pipelines/build-whl-pipeline.yml) to build.whland.pydfiles for multiple Python versions (3.10–3.13) and architectures (x64, arm64). It includes steps for dependency installation, artifact publishing, and ARM64-specific handling.eng/pipelines/test-pipeline.yml) to usebuild.batfor building.pydfiles and updated artifact paths to include versioned.pydfilenames. [1] [2]Python Bindings Improvements
ddbc_bindings.pyto locate and load the correct.pydfile based on the current Python version and architecture. Includes fallback logic for unmatched configurations.CMakeLists.txtto support Python version detection, architecture-specific builds, and improved compatibility with modern C++ standards (C++17). Added debug messages and fallback mechanisms for Python library paths.Code Cleanup
printstatements from connection string construction methods inconnection.pyandhelpers.pyto clean up logging. [1] [2]Documentation Updates
README.mdin thepybinddirectory with clearer build instructions, including updated prerequisites, build steps, and an explanation of thebuild.batscript.