-
Notifications
You must be signed in to change notification settings - Fork 27
FEAT: Build process for Mac Support #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances macOS support by improving dynamic library path handling in the shell script and simplifies dependency management in the wheel build process.
- Updated library path handling in configure_dylibs.sh to use @loader_path for dynamic linking and set library IDs.
- Updated setup.py to import bdist_wheel directly from the wheel package.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| setup.py | Changed import of bdist_wheel to use the wheel package. |
| mssql_python/pybind/configure_dylibs.sh | Updated dynamic linking paths and added library ID settings. |
bewithgaurav
commented
Jun 2, 2025
sumitmsft
approved these changes
Jun 2, 2025
codewatchzen
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the Python library detection process, updates dependency handling for macOS dynamic libraries, enhances security in connection string sanitization, and refactors the
setup.pyfile to use a different module for wheel building.Python library detection improvements:
mssql_python/pybind/CMakeLists.txt: Added logic to handle cases wherePYTHON_LIB_DIRis not set or is empty on Windows, using Python'ssysconfigto locate the library directory. Additionally, support for a custom environment variableCUSTOM_PYTHON_LIB_DIRwas added to override the library directory.Dependency handling updates for macOS:
mssql_python/pybind/configure_dylibs.sh: Updatedinstall_name_toolcommands to use@loader_pathfor dynamic library paths, ensuring better portability. Added commands to set library IDs explicitly using@loader_path.Security enhancement in connection string sanitization:
mssql_python/pybind/ddbc_bindings_mac.cpp: Improved theSanitizeConnectionStringfunction to perform case-insensitive removal of sensitive parameters (UIDandPwd) by converting the string to lowercase for comparison.Refactor in wheel building:
setup.py: Changed the import fromsetuptools.command.bdist_wheeltowheel.bdist_wheelfor building platform-specific wheels.