-
Notifications
You must be signed in to change notification settings - Fork 354
Closed
Labels
Description
Expected Behavior
No crash
Actual Behavior
Crash, all NTVS versions
Steps to Reproduce
- Edit the
%PATH%environment variable to contain an invalid entry, such as a control character. - Invoke NTVS code in such a way that
GetPathToNodeExecutableFromEnvironmentreaches the section where it checks the users PATH. Usingvstest.console.exeis one way to do this. - Crash in the section:
foreach (var dir in Environment.GetEnvironmentVariable("PATH").Split(Path.PathSeparator)) {
var execPath = Path.Combine(dir, executable);
if (File.Exists(execPath))
return execPath;
}on the line with Path.Combine