Prototype: Port Open Folder Node Debug Provider to NTVS #1120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change takes the existing node debugger provider embedded in the Open Folder team's code base, and moves it into the NTVS code. This will allow us to maintain the debug provider going forward. Testing Tested on VS15. There seems to be a bug with anycode where `ProviderPriority` is not respected, so the builtin copy of the node debug provider is always used over this new debug provider in the NTVS codebase. I changed the file extension type to test this change, and saw this debug provider being used.
| @@ -0,0 +1,11 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
Contributor
Author
There was a problem hiding this comment.
All these changes and files were generated by package manager when I added the new deps.
Contributor
Author
|
Looks like the nuget path provided ( https://mseng.pkgs.visualstudio.com/DefaultCollection/_packaging/VSIDEProj-TestSigned-Release/nuget/v3/index.json ) is Microsoft internal, which I believe is why AppVeyor failed. I'll reach out the the Open Folder team to confirm this. Also, AppVeyor does not seem to be building dev15. Will see if I can add that. |
Contributor
Author
|
Opened #1121 to track dev15 AppVeyor work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1112
This change takes the existing node debugger provider embedded in the Open Folder team's codebase, and moves it into the NTVS code. This will allow us to maintain the debug provider going forward.
Testing
Tested on VS15. There seems to be a bug with the Open Folder where
ProviderPriorityis not respected, so the builtin copy of the node debug provider is always used over this new debug provider. I changed the file extension type to test this change, and saw this debug provider being used.