Skip to content

Fix potential crash for weird %PATH% #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2016
Merged

Fix potential crash for weird %PATH% #1212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Nodejs/Product/Nodejs/Nodejs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,12 @@ public static string GetPathToNodeExecutableFromEnvironment(string executable =

// If we didn't find node.js in the registry we should look at the user's path.
foreach (var dir in Environment.GetEnvironmentVariable("PATH").Split(Path.PathSeparator)) {
var execPath = Path.Combine(dir, executable);
if (File.Exists(execPath)) {
return execPath;
}
try {
var execPath = Path.Combine(dir, executable);
if (File.Exists(execPath)) {
return execPath;
}
} catch (ArgumentException) { /*noop*/ }
}

// It wasn't in the users path. Check Program Files for the nodejs folder.
Expand Down