Skip to content

Conversation

@hoanhtien
Copy link
Contributor

NodejsPackage.Instance is not available in unit testing. This fixes #409.

@msftclas
Copy link

msftclas commented Sep 3, 2015

Hi @hoanhtien, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Tien Nguyen). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@mousetraps
Copy link
Contributor

👍

mousetraps added a commit that referenced this pull request Sep 3, 2015
Fix #409 - Add null check for NodejsPackage.Instance.
@mousetraps mousetraps merged commit ce96c61 into microsoft:master Sep 3, 2015
@hoanhtien hoanhtien deleted the NodejsPackageInstanceNullCheck branch September 3, 2015 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed test case: CannonicalHelloWorldTest

4 participants