Fix ProblematicPackageJsonTests. #539
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This fixes the tests in VS2015, but breaks them in VS2013. The exception only began ocurring in VS2015, which depends on Newtonsoft.Json 6.0, not 4.5 - see this commit comment for more info. 155a341#diff-783b0bc1c65b5cb6b1ee09a119cd29eb As mentioned in the comment, Newtonsoft.Json 6.0 reliance in NTVS was only supposed to be temporary, but unfortunately VS 2015 never fixed their binding redirect issue. At this point, we may as well bite the bullet and move to Newtonsoft.Json 6.0 everywhere rather than conditionally in VS2015 to keep our codepaths more predictable across VS versions. |
This was referenced Dec 12, 2015
Closed
Contributor
|
Closing this PR, as it's not the right way to go about addressing the issue. Opened #645 to track. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exceptions are expected for MissingTralingBrace and MissingTrailingListBrace tests.