Skip to content

Conversation

@sfatimar
Copy link
Contributor

This change is to ensure that samples are valid for both dGPU and iGPU in a multi gpu system

@sfatimar
Copy link
Contributor Author

@jywu-msft Please review

@jywu-msft
Copy link
Member

jywu-msft commented Nov 29, 2022

I think it would be nice to provide some more details in the README to explain the differences between the two squeezenet samples.
The user may not be familiar with "iobuffer optimization" and what it means.
Would it be better to say one example is for cpu and the other one is for running on gpu's (and the optimization is there for memory copy avoidance?)

@sfatimar
Copy link
Contributor Author

sfatimar commented Dec 5, 2022

I think it would be nice to provide some more details in the README to explain the differences between the two squeezenet samples. The user may not be familiar with "iobuffer optimization" and what it means. Would it be better to say one example is for cpu and the other one is for running on gpu's (and the optimization is there for memory copy avoidance?)

We have made the change

@sfatimar
Copy link
Contributor Author

@jywu-msft Please merge

@jywu-msft jywu-msft merged commit cd1c8ac into microsoft:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants