Update SuperRes ios app to released version ort-ext pods and some other minor refinements #208

YUNQIUGUO · 2023-02-17T21:02:23Z

Update SuperRes ios app to released version ort-ext pods and opset18 version model
Refine app UI to display the output image in one screen
Readme updates

YUNQIUGUO · 2023-02-17T21:36:39Z

I also tried to update the way to register custom ops using function name approach here , but got a symbol not found error, not sure if any extra set up is required:

onnxruntime-inference-examples/mobile/examples/super_resolution/ios/ORTSuperResolution/ORTSuperResolution/ORTSuperResolutionPerformer.mm

Lines 32 to 34 in 34de606

    
           if (RegisterCustomOps(session_options, OrtGetApiBase()) != nullptr) { 
        
               throw std::runtime_error("RegisterCustomOps failed"); 
        
           }

using:
session_options.RegisterCustomOpsUsingFunction("RegisterCustomOps");
and latest ort-ext pod and onnxruntime-c pod

edgchen1 · 2023-02-17T21:40:48Z

mobile/examples/super_resolution/ios/ORTSuperResolution/Podfile

-  # Pre-release version pods
-  pod 'onnxruntime-extensions-c', '0.5.0-dev+261962.e3663fb'
+  # Release version pod for ort-ext
+  pod 'onnxruntime-extensions-c', '0.6.0'


just use the latest?

Suggested change

pod 'onnxruntime-extensions-c', '0.6.0'

pod 'onnxruntime-extensions-c'

natke

A couple of minor comments

natke · 2023-02-17T22:42:21Z

mobile/README.md


 - [Android Super Resolution](examples/super_resolution/android)
- [iOS Super Resolution](examples/speech_recognition/ios)
+- [iOS Super Resolution](examples/super_resolution/ios)


natke · 2023-02-17T22:42:43Z

...xamples/super_resolution/ios/ORTSuperResolution/ORTSuperResolution.xcodeproj/project.pbxproj

 	objects = {

 /* Begin PBXBuildFile section */
-		510A53D6296DE390000DB268 /* pt_super_resolution_with_pre_post_processing_opset16.onnx in Resources */ = {isa = PBXBuildFile; fileRef = 510A53D5296DE390000DB268 /* pt_super_resolution_with_pre_post_processing_opset16.onnx */; };


Should this file be under source control?

this is the older opset16 version model, do we still want to keep that model in the project?

also fyi .pbxproj file updates are auto-generated after updating the ios app.

I'd prefer we only have the opset 18 model given that will have significantly better output.

also fyi .pbxproj file updates are auto-generated after updating the ios app.

That's why I wondered the pbxporj file should be under version control? If it gets re-generated. Not a biggie

skottmckay · 2023-02-17T23:14:37Z

...xamples/super_resolution/ios/ORTSuperResolution/ORTSuperResolution.xcodeproj/project.pbxproj

 				5130D9C32968B93C009B4B88 /* Preview Assets.xcassets in Resources */,
 				5130D9C02968B93C009B4B88 /* Assets.xcassets in Resources */,
 				510A53E8296FE46F000DB268 /* cat_224x224.png in Resources */,
+				5197BE9E29A026B3004B83DE /* pytorch_superresolution_with_pre_post_processing_op18.onnx in Resources */,


nit: 'op18' is a bit obtuse vs 'opset18'.

True! I did confuse op16 with fp16 :-)

skottmckay · 2023-02-17T23:16:19Z

mobile/examples/super_resolution/ios/ORTSuperResolution/ORTSuperResolution/ContentView.swift

                    }

                    if performSuperRes {
                        Text("Output high resolution image: ").frame(width: 350, height: 40, alignment:.leading)


nit: would 'higher resolution image' lower user expectations of extra special magic happening?

skottmckay · 2023-02-17T23:16:46Z

...xamples/super_resolution/ios/ORTSuperResolution/ORTSuperResolution.xcodeproj/project.pbxproj

 	objects = {

 /* Begin PBXBuildFile section */
-		510A53D6296DE390000DB268 /* pt_super_resolution_with_pre_post_processing_opset16.onnx in Resources */ = {isa = PBXBuildFile; fileRef = 510A53D5296DE390000DB268 /* pt_super_resolution_with_pre_post_processing_opset16.onnx */; };


I'd prefer we only have the opset 18 model given that will have significantly better output.

edgchen1 · 2023-02-21T18:12:47Z

...xamples/super_resolution/ios/ORTSuperResolution/ORTSuperResolution.xcodeproj/project.pbxproj

 		5130D9C02968B93C009B4B88 /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 5130D9BF2968B93C009B4B88 /* Assets.xcassets */; };
 		5130D9C32968B93C009B4B88 /* Preview Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 5130D9C22968B93C009B4B88 /* Preview Assets.xcassets */; };
+		5197BEA129A0492D004B83DE /* pytorch_superresolution_with_pre_post_processing_opset18.onnx in Resources */ = {isa = PBXBuildFile; fileRef = 5197BEA029A0492D004B83DE /* pytorch_superresolution_with_pre_post_processing_opset18.onnx */; };
+		5197BEA229A0492D004B83DE /* pytorch_superresolution_with_pre_post_processing_opset18.onnx in Resources */ = {isa = PBXBuildFile; fileRef = 5197BEA029A0492D004B83DE /* pytorch_superresolution_with_pre_post_processing_opset18.onnx */; };


why are there two entries here for pytorch_superresolution_with_pre_post_processing_opset18.onnx? was it added twice?

why are there two entries here for pytorch_superresolution_with_pre_post_processing_opset18.onnx? was it added twice?

I think one is for ORTSuperResolution and one is for ORTSuperResolutionTest. I added the model to both targets.

shahicasper

apply

rachguo added 4 commits February 17, 2023 11:35

update pod version to release version

1d8cab9

refine the app

8bef339

readme fix

a392635

update screenshot

9e3e9ff

YUNQIUGUO requested review from edgchen1, natke and skottmckay February 17, 2023 21:02

YUNQIUGUO and others added 2 commits February 17, 2023 13:05

Merge branch 'main' into yguo/update-ios-superes-to-official-package

9abeacd

fix

5fd1cc0

edgchen1 reviewed Feb 17, 2023

View reviewed changes

omit version using latest

28173fc

natke approved these changes Feb 17, 2023

View reviewed changes

skottmckay reviewed Feb 17, 2023

View reviewed changes

update comments

ce7a5bd

edgchen1 reviewed Feb 21, 2023

View reviewed changes

Merge branch 'main' into yguo/update-ios-superes-to-official-package

f4c64c7

YUNQIUGUO merged commit 7f6a172 into main Feb 22, 2023

YUNQIUGUO deleted the yguo/update-ios-superes-to-official-package branch February 22, 2023 16:40

shahicasper reviewed Apr 16, 2023

View reviewed changes

	pod 'onnxruntime-extensions-c', '0.6.0'
	pod 'onnxruntime-extensions-c'

Update SuperRes ios app to released version ort-ext pods and some other minor refinements #208

Update SuperRes ios app to released version ort-ext pods and some other minor refinements #208

Uh oh!

Conversation

YUNQIUGUO commented Feb 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

YUNQIUGUO commented Feb 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

natke left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

YUNQIUGUO Feb 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shahicasper left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

YUNQIUGUO commented Feb 17, 2023 •

edited

Loading

YUNQIUGUO commented Feb 17, 2023 •

edited

Loading

YUNQIUGUO Feb 17, 2023 •

edited

Loading