Skip to content

Conversation

@migueldeicaza
Copy link
Contributor

Description: Slight updates to guide folks trying to add a new execution provider for the first time

Motivation and Context

Spent a bunch of time googling to find answers with no luck, until I ran into a CI script,
so I am trying to solve the pain for future folks

Slight updates to guide folks trying to add a new execution provider for the first time
@migueldeicaza migueldeicaza requested a review from a team as a code owner January 6, 2021 15:49
@edgchen1
Copy link
Contributor

edgchen1 commented Jan 6, 2021

# Testing your execution provider
To ease the testing of your execution provider, you can add a new case for it to the `onnx_test_runner` command,
do this by adding it to `onnxruntime/test/onnx/main.cc` file, following the pattern for other existing providers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The onnxruntime_perf_test can be updated as well, to help measure the perf of new EP
onnxruntime/test/perftest/command_args_parser.cc

@stale
Copy link

stale bot commented Jun 11, 2021

This issue has been automatically marked as stale due to inactivity and will be closed in 7 days if no further activity occurs. If further support is needed, please provide an update and/or more details.

@stale stale bot added the stale issues that have not been addressed in a while; categorized by a bot label Jun 11, 2021
@migueldeicaza
Copy link
Contributor Author

Well, looks like this will get automatically closed. I feel bad for future folks that might want to avoid this pain.

@stale stale bot removed the stale issues that have not been addressed in a while; categorized by a bot label Jun 14, 2021
faxu added a commit to faxu/onnxruntime that referenced this pull request Aug 5, 2021
@faxu
Copy link
Contributor

faxu commented Aug 5, 2021

@migueldeicaza, thank you so much for this contribution and apologies that this fell through the cracks. I've incorporated the changes in the latest iteration of that doc #8612, which is now hosted on the github.io documentation site.

@faxu faxu closed this Aug 5, 2021
faxu added a commit that referenced this pull request Aug 10, 2021
* fix links

* update order of api nav

* update execution provider how to, original PR #6266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants