Skip to content

Implement aten::round.decimals | feat(torchlib) #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2023
Merged

Implement aten::round.decimals | feat(torchlib) #1028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4ecd92
Implement `aten::round.decimals` | feat(torchlib)
justinchuby Aug 25, 2023
d2ffad2
Simplify
justinchuby Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions onnxscript/function_libs/torch_lib/ops/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5972,6 +5972,18 @@ def aten_round(self: TFloat) -> TFloat:
return op.Round(self)


@torch_op("aten::round.decimals")
def aten_round_decimals(self: TFloat, decimals: int = 0) -> TFloat:
"""round.decimals(Tensor self, *, int decimals) -> Tensor"""

# Scale the input by 10^decimals, round it, and scale it back.
ten = op.CastLike(10.0, self)
scale = op.Pow(ten, op.CastLike(decimals, self))
self_scaled = op.Mul(self, scale)
rounded = op.Round(self_scaled)
return op.Div(rounded, scale)


def aten_row_indices(self: TensorType) -> TensorType:
"""row_indices(Tensor(a) self) -> Tensor(a)"""

Expand Down
13 changes: 6 additions & 7 deletions onnxscript/tests/function_libs/torch_lib/ops_test_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1153,23 +1153,21 @@ def _where_input_wrangler(
TorchLibOpInfo("reshape", core_ops.aten_reshape),
TorchLibOpInfo("resolve_conj", core_ops.aten_resolve_conj),
TorchLibOpInfo("resolve_neg", core_ops.aten_resolve_neg),
TorchLibOpInfo(
"round",
core_ops.aten_round,
)
TorchLibOpInfo("round", core_ops.aten_round)
.xfail(
variant_name="decimals_0",
reason="The op does not support decimals yet",
reason="This variant does not accept decimals",
test_class_name="TestOutputConsistencyEager",
)
.xfail(
variant_name="decimals_3",
reason="The op does not support decimals yet",
reason="This variant does not accept decimals",
)
.xfail(
variant_name="decimals_neg_3",
reason="The op does not support decimals yet",
reason="This variant does not accept decimals",
),
TorchLibOpInfo("round_decimals", core_ops.aten_round_decimals),
TorchLibOpInfo("rsqrt", core_ops.aten_rsqrt),
TorchLibOpInfo("rsub", core_ops.aten_rsub),
TorchLibOpInfo(
Expand Down Expand Up @@ -1939,6 +1937,7 @@ def _where_input_wrangler(
"nn.functional.upsample_nearest3d",
),
)
ops_test_common.duplicate_opinfo(OPS_DB, "round", ("round_decimals",))
ops_test_common.duplicate_opinfo(OPS_DB, "squeeze", ("squeeze_dim",))
ops_test_common.duplicate_opinfo(OPS_DB, "var_mean", ("var_mean_dim", "var_mean_correction"))
ops_test_common.duplicate_opinfo(OPS_DB, "view_as_complex", ("view_as_complex_copy",))
Expand Down