-
Notifications
You must be signed in to change notification settings - Fork 86
Implements aten_index_put if inputs are SymbolicTensor #2606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
3cb493f
Implements aten_index_put if inputs are SymbolicTensor
xadupre c9472f3
disable case with one index
xadupre 434fcfb
type constant
xadupre 5cf4882
Merge branch 'main' of https://github.com/microsoft/onnxscript into i…
xadupre ae6adca
another fix
xadupre 8510364
rename
xadupre e4d574a
style
xadupre 86d482d
lint
xadupre 8305cac
fix merge conflicts
xadupre 02dda0e
Merge branch 'main' of https://github.com/microsoft/onnxscript into i…
xadupre e6f7633
Merge branch 'main' of https://github.com/microsoft/onnxscript into i…
xadupre e108dc3
rename
xadupre 988e9f6
handle one more case for index_put
xadupre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a pointer to the real use-cases that show up? I thought each index in indices is supposed to be a 1D tensor? What are the ways in which SymbolicTensors are created?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is a SymbolicTensor a 1-element tensor version of a SymbolicInt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SymbolicTensor is just ir.Value with magic methods defined to support python operators.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the symbolic tensors are created from the symints.