Skip to content

Conversation

@titaiwangms
Copy link
Contributor

Fixes #2673

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 78.04878% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.11%. Comparing base (1a27df1) to head (1c7fc2c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
onnxscript/optimizer/_constant_folding.py 73.52% 3 Missing and 6 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2679   +/-   ##
=======================================
  Coverage   70.11%   70.11%           
=======================================
  Files         224      224           
  Lines       26956    26982   +26     
  Branches     2700     2705    +5     
=======================================
+ Hits        18899    18919   +20     
- Misses       7126     7129    +3     
- Partials      931      934    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@titaiwangms titaiwangms enabled auto-merge (squash) November 4, 2025 00:03
@justinchuby justinchuby disabled auto-merge November 4, 2025 00:10
Copy link
Collaborator

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - minor comments. Would be good to get another eye from @gramalingam

@titaiwangms titaiwangms enabled auto-merge (squash) November 5, 2025 01:13
@titaiwangms titaiwangms merged commit d80575d into microsoft:main Nov 5, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in ONNX Script Review Board Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

Constant-folding behavior inside functions

3 participants