-
Notifications
You must be signed in to change notification settings - Fork 90
Keep creating constants when constants are folded inside ir.Function #2679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep creating constants when constants are folded inside ir.Function #2679
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2679 +/- ##
=======================================
Coverage 70.11% 70.11%
=======================================
Files 224 224
Lines 26956 26982 +26
Branches 2700 2705 +5
=======================================
+ Hits 18899 18919 +20
- Misses 7126 7129 +3
- Partials 931 934 +3 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
justinchuby
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - minor comments. Would be good to get another eye from @gramalingam
Fixes #2673