[torchlib] Fix mod on SymInt #2686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
justinchuby
added
the
module: torchlib
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2686 +/- ##
==========================================
- Coverage 70.11% 70.11% -0.01%
==========================================
Files 225 225
Lines 27068 27083 +15
Branches 2721 2721
==========================================
+ Hits 18980 18990 +10
- Misses 7148 7153 +5
Partials 940 940 ☔ View full report in Codecov by Sentry. |
titaiwangms
approved these changes
Nov 7, 2025
|
|
||
|
|
||
| @torch_op("_operator::ge", trace_only=True) | ||
| def operator_ge(self: TTensor, other: TTensor) -> BOOL: |
Collaborator
Author
There was a problem hiding this comment.
This is more lenient, which I think is ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the error:
<class 'AttributeError'>: 'int' object has no attribute 'dtype'by splitting the implementation out foroperator.*ops.