Skip to content

[Do not merge] Debug min/max with ORT #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

[Do not merge] Debug min/max with ORT #986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0a0e7b5
[Do not merge] Debug min/max with ORT
justinchuby Aug 7, 2023
fc56c1e
Remove parallel
justinchuby Aug 7, 2023
6a82bbb
Merge branch 'main' into justinchu/min-max-debug
justinchuby Aug 7, 2023
d7bb189
Merge branch 'main' into justinchu/min-max-debug
justinchuby Aug 8, 2023
1b4bf70
Merge branch 'main' into justinchu/min-max-debug
justinchuby Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
- name: Install nox
run: python -m pip install nox
- name: Run tests
run: nox -t ${{ matrix.nox-tag }} --forcecolor -- -v --cov=onnxscript --cov-report=xml --cov-append --cov-branch -n=auto --junit-xml pytest.xml
run: nox -t ${{ matrix.nox-tag }} --forcecolor -- --cov=onnxscript --cov-report=xml --cov-append --cov-branch --junit-xml pytest.xml -s
env:
CATCH_ORT_SEGFAULT: "${{ matrix.os == 'ubuntu-latest' && '1' || '0' }}"
CREATE_REPRODUCTION_REPORT: "${{ matrix.os == 'ubuntu-latest' && '1' || '0' }}"
Expand Down
3 changes: 3 additions & 0 deletions onnxscript/tests/function_libs/torch_lib/ops_test_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,6 +524,9 @@ def _capture_graph_and_evaluate_torch_script_evaluator(function: Callable, args,
f"ONNX model is invalid. Model:\n{onnxscript.proto2text(onnx_model)}"
) from e

if ("min" in test_name or "max" in test_name) and "pool" not in test_name:
print(test_name, "ort_inputs", ort_inputs)

try:
if (
os.environ.get("CATCH_ORT_SEGFAULT") == "1"
Expand Down