ohcl_boot: Always enable logging ASAP #1876
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enables early logging by default when running in environments where the host can be trusted, removing the need for explicit configuration in such scenarios. Previously, early logging was only automatically enabled when the confidential debug environment variable was set.
Key changes:
- Moves logger initialization logic to occur after determining host trustworthiness
- Automatically enables serial logging when host can be trusted and no explicit logger is configured
- Removes automatic logger setup from confidential debug flag parsing
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| openhcl/openhcl_boot/src/main.rs | Relocates logger initialization logic and adds automatic serial logging for trusted host environments |
| openhcl/openhcl_boot/src/cmdline.rs | Removes automatic logger setup from confidential debug flag parsing |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
smalis-msft
changed the title
|
Does ARM ohcl boot serial not work on hyper-v? |
COM3 openhcl logs do not work on ARM Hyper-V today. I just talked to Mike about this and it should be possible to add support in the Hyper-V PL011 emulator. |
Do we have that tracked in ADO somewhere? I'll just remove it from here for now, but I don't want to lose that. |
|
Confirmed that I see openhcl_boot logs in vmm test output now. |
3 participants
There's no reason not to have it. This also removes the configuration of logging and the ability to disable it, since we still only have the one output backend.