[core]: Remove azure-storage-blob pin #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 1, 2023 20:24
This removes the pin on azure-storge-blob. Based on the comment, I think this was fixed in https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/storage/azure-storage-blob/CHANGELOG.md#12110-2022-03-29 > Fixed a bug in BlobSasPermissions where the tag permission had a > default value of True and therefore was being added to the SAS token by > default. I'm interested in the changes at https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/storage/azure-storage-blob/CHANGELOG.md#other-changes-2. > Changed the default value for read_timeout to 60 seconds for all > clients. This which will help resolve the apparent hangs we've been seeing.
|
Also having to bump mypy to avoid |
|
15d3bef fixes a typing issue that the newer mypy seems to have correctly identified (passing a |
added 2 commits
May 5, 2023 08:24
|
I also bumped the pctasks versions so that downstream packages can bring this in. |
4 tasks
TomAugspurger
pushed a commit
that referenced
this pull request
May 18, 2023
This bumps the goes-glm pipeline to a new version, picking up the newer version of azure-storage-blob unlocked in #193.
TomAugspurger
pushed a commit
that referenced
this pull request
May 19, 2023
This bumps the goes-glm pipeline to a new version, picking up the newer version of azure-storage-blob unlocked in #193.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the pin on azure-storge-blob.
Based on the comment, I think this was fixed in
https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/storage/azure-storage-blob/CHANGELOG.md#12110-2022-03-29
I'm interested in the changes at
https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/storage/azure-storage-blob/CHANGELOG.md#other-changes-2.
This which will help resolve the apparent hangs we've been seeing.