Skip to content

test: cleanup user-data-dir after tests in TestDefaultBrowserContext2 #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2022
Merged

test: cleanup user-data-dir after tests in TestDefaultBrowserContext2 #1112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions playwright/src/test/java/com/microsoft/playwright/TestDefaultBrowserContext2.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.condition.DisabledIf;
import org.junit.jupiter.api.io.TempDir;

import java.io.IOException;
import java.nio.file.Files;
Expand All @@ -22,6 +23,7 @@ public class TestDefaultBrowserContext2 extends TestBase {


private BrowserContext persistentContext;
@TempDir Path tempDir;

@AfterEach
private void closePersistentContext() {
Expand All @@ -36,12 +38,7 @@ private Page launchPersistent() {
}

private Page launchPersistent(BrowserType.LaunchPersistentContextOptions options) {
Path userDataDir = null;
try {
userDataDir = Files.createTempDirectory("user-data-dir-");
} catch (IOException e) {
throw new RuntimeException(e);
}
Path userDataDir = tempDir.resolve("user-data-dir");
assertNull(persistentContext);
persistentContext = browserType.launchPersistentContext(userDataDir, options);
return persistentContext.pages().get(0);
Expand Down Expand Up @@ -118,7 +115,7 @@ void shouldSupportExtraHTTPHeadersOption() throws ExecutionException, Interrupte
@Test
void shouldAcceptUserDataDir() throws IOException {
// TODO: test.flaky(browserName === "chromium");
Path userDataDir = Files.createTempDirectory("user-data-dir-");
Path userDataDir = tempDir.resolve("user-data-dir");
BrowserContext context = browserType.launchPersistentContext(userDataDir);
assertTrue(userDataDir.toFile().listFiles().length > 0);
context.close();
Expand All @@ -128,7 +125,7 @@ void shouldAcceptUserDataDir() throws IOException {
@Test
void shouldRestoreStateFromUserDataDir() throws IOException {
// TODO: test.slow();
Path userDataDir = Files.createTempDirectory("user-data-dir-");
Path userDataDir = tempDir.resolve("user-data-dir");
BrowserType.LaunchPersistentContextOptions browserOptions = null;
BrowserContext browserContext = browserType.launchPersistentContext(userDataDir, browserOptions);
Page page = browserContext.newPage();
Expand All @@ -142,7 +139,7 @@ void shouldRestoreStateFromUserDataDir() throws IOException {
assertEquals("hello", page2.evaluate("localStorage.hey"));
browserContext2.close();

Path userDataDir2 = Files.createTempDirectory("user-data-dir-");
Path userDataDir2 = tempDir.resolve("user-data-dir-2");
BrowserContext browserContext3 = browserType.launchPersistentContext(userDataDir2, browserOptions);
Page page3 = browserContext3.newPage();
page3.navigate(server.EMPTY_PAGE);
Expand All @@ -153,7 +150,7 @@ void shouldRestoreStateFromUserDataDir() throws IOException {
@Test
void shouldRestoreCookiesFromUserDataDir() throws IOException {
// TODO: test.flaky(browserName === "chromium");
Path userDataDir = Files.createTempDirectory("user-data-dir-");
Path userDataDir = tempDir.resolve("user-data-dir");
BrowserType.LaunchPersistentContextOptions browserOptions = null;
BrowserContext browserContext = browserType.launchPersistentContext(userDataDir, browserOptions);
Page page = browserContext.newPage();
Expand All @@ -171,7 +168,7 @@ void shouldRestoreCookiesFromUserDataDir() throws IOException {
assertEquals("doSomethingOnlyOnce=true", page2.evaluate("() => document.cookie"));
browserContext2.close();

Path userDataDir2 = Files.createTempDirectory("user-data-dir-");
Path userDataDir2 = tempDir.resolve("user-data-dir-2");
BrowserContext browserContext3 = browserType.launchPersistentContext(userDataDir2, browserOptions);
Page page3 = browserContext3.newPage();
page3.navigate(server.EMPTY_PAGE);
Expand All @@ -191,7 +188,7 @@ void shouldHaveDefaultURLWhenLaunchingBrowser() {
void shouldThrowIfPageArgumentIsPassed() throws IOException {
BrowserType.LaunchPersistentContextOptions options = new BrowserType.LaunchPersistentContextOptions()
.setArgs(asList(server.EMPTY_PAGE));
Path userDataDir = Files.createTempDirectory("user-data-dir-");
Path userDataDir = tempDir.resolve("user-data-dir");
PlaywrightException e = assertThrows(PlaywrightException.class, () -> {
browserType.launchPersistentContext(userDataDir, options);
});
Expand Down