Skip to content

chore: roll driver to 1.28.1 #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2022
Merged

chore: roll driver to 1.28.1 #1133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 29 additions & 20 deletions playwright/src/test/java/com/microsoft/playwright/TestSelectorsRole.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,26 +153,35 @@ void shouldSupportPressed() {

@Test
void shouldSupportExpanded() {
page.setContent("<button>Hi</button>\n" +
" <button aria-expanded=\"true\">Hello</button>\n" +
" <button aria-expanded=\"false\">Bye</button>");
assertEquals(asList(
"<button aria-expanded=\"true\">Hello</button>"
), page.locator("role=button[expanded]").evaluateAll("els => els.map(e => e.outerHTML)"));
assertEquals(asList(
"<button aria-expanded=\"true\">Hello</button>"
), page.locator("role=button[expanded=true]").evaluateAll("els => els.map(e => e.outerHTML)"));
assertEquals(asList(
"<button aria-expanded=\"true\">Hello</button>"
), page.getByRole(AriaRole.BUTTON, new Page.GetByRoleOptions().setExpanded(true)).evaluateAll("els => els.map(e => e.outerHTML)"));
assertEquals(asList(
"<button>Hi</button>",
"<button aria-expanded=\"false\">Bye</button>"
), page.locator("role=button[expanded=false]").evaluateAll("els => els.map(e => e.outerHTML)"));
assertEquals(asList(
"<button>Hi</button>",
"<button aria-expanded=\"false\">Bye</button>"
), page.getByRole(AriaRole.BUTTON, new Page.GetByRoleOptions().setExpanded(false)).evaluateAll("els => els.map(e => e.outerHTML)"));
page.setContent("<div role=\"treeitem\">Hi</div>\n" +
" <div role=\"treeitem\" aria-expanded=\"true\">Hello</div>\n" +
" <div role=\"treeitem\" aria-expanded=\"false\">Bye</div>");
assertEquals(asList(
"<div role=\"treeitem\">Hi</div>",
"<div role=\"treeitem\" aria-expanded=\"true\">Hello</div>",
"<div role=\"treeitem\" aria-expanded=\"false\">Bye</div>"
), page.locator("role=treeitem").evaluateAll("els => els.map(e => e.outerHTML)"));
assertEquals(asList(
"<div role=\"treeitem\">Hi</div>",
"<div role=\"treeitem\" aria-expanded=\"true\">Hello</div>",
"<div role=\"treeitem\" aria-expanded=\"false\">Bye</div>"
), page.getByRole(AriaRole.TREEITEM).evaluateAll("els => els.map(e => e.outerHTML)"));

assertEquals(asList("<div role=\"treeitem\" aria-expanded=\"true\">Hello</div>"),
page.locator("role=treeitem[expanded]").evaluateAll("els => els.map(e => e.outerHTML)"));
assertEquals(asList("<div role=\"treeitem\" aria-expanded=\"true\">Hello</div>"),
page.locator("role=treeitem[expanded=true]").evaluateAll("els => els.map(e => e.outerHTML)"));
assertEquals(asList("<div role=\"treeitem\" aria-expanded=\"true\">Hello</div>"),
page.getByRole(AriaRole.TREEITEM, new Page.GetByRoleOptions().setExpanded(true)).evaluateAll("els => els.map(e => e.outerHTML)"));

assertEquals(asList("<div role=\"treeitem\" aria-expanded=\"false\">Bye</div>"),
page.locator("role=treeitem[expanded=false]").evaluateAll("els => els.map(e => e.outerHTML)"));
assertEquals(asList("<div role=\"treeitem\" aria-expanded=\"false\">Bye</div>"),
page.getByRole(AriaRole.TREEITEM, new Page.GetByRoleOptions().setExpanded(false)).evaluateAll("els => els.map(e => e.outerHTML)"));

// Workaround for expanded='none'.
assertEquals(asList("<div role=\"treeitem\">Hi</div>"),
page.locator("[role=treeitem]:not([aria-expanded])").evaluateAll("els => els.map(e => e.outerHTML)"));
}

@Test
Expand Down
2 changes: 1 addition & 1 deletion scripts/CLI_VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.28.0
1.28.1