Skip to content

test: align waitForNavigation test with upstream #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2023
Merged

test: align waitForNavigation test with upstream #1250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions playwright/src/test/java/com/microsoft/playwright/TestPageWaitForNavigation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,16 +241,18 @@ void shouldFailWhenFrameDetaches() throws InterruptedException {
page.navigate(server.PREFIX + "/frames/one-frame.html");
Frame frame = page.frames().get(1);
server.setRoute("/empty.html", exchange -> {});
server.setRoute("/one-style.css", exchange -> {});
PlaywrightException ex = assertThrows(PlaywrightException.class, () -> {
frame.waitForNavigation(() -> {
Future<Server.Request> req = server.futureRequest("/empty.html");
page.evalOnSelector("iframe", "frame => { frame.contentWindow.location.href = '/empty.html'; }");
Future<Server.Request> req = server.futureRequest("/one-style.css");
page.evalOnSelector("iframe", "frame => { frame.contentWindow.location.href = '/one-style.html'; }");
try {
// Make sure policy checks pass and navigation actually begins before removing the frame to avoid other errors
req.get();
} catch (InterruptedException | ExecutionException e) {
throw new RuntimeException(e);
}
page.evaluate("setTimeout(() => document.querySelector('iframe').remove());");
page.evalOnSelector("iframe", "frame => setTimeout(() => frame.remove(), 0)");
});
});
assertTrue(ex.getMessage().contains("frame was detached"), ex.getMessage());
Expand Down