test: Restrain sending http credentials on a specific origin (for roll 1.33 driver) #1253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
reviewed
Apr 12, 2023
Member
yury-s
left a comment
yury-s
left a comment
There was a problem hiding this comment.
We finally rolled driver to 1.33. Can you rebase your PR on top of the main branch? The tests should be passing now.
…ver 1.33 roll) Verify that the httpCredentials are not sent when origin mismatch (scheme or hostname or port). See microsoft/playwright#20374
Contributor
Author
|
Rebased on top of main branch. |
yury-s
approved these changes
Apr 18, 2023
Member
yury-s
left a comment
yury-s
left a comment
There was a problem hiding this comment.
Let's also port tests with matching credentials:
should work with correct credentials and matching origin and
should work with correct credentials and matching origin case insensitive
Verify that the httpCredentials are not sent when origin mismatch (scheme or hostname or port). See microsoft/playwright#20374
Contributor
Author
|
@yury-s All set. |
yury-s
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify that the httpCredentials are not sent when origin mismatches (scheme or hostname or port different). See microsoft/playwright#20374
It works on my side with roll of driver version 1.33.0-alpha-mar-28-2023 (I did not push the actual roll, I'll let you guys do it since other implementation may also need tests).