test: fix Chromium tests on Windows #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
mxschmitt-patch-4
branch
from
5d86188 to
7539a5c
Compare
mxschmitt
commented
May 27, 2025
|
|
||
|
|
||
| @pytest.fixture | ||
| def pytester(pytester: pytest.Pytester) -> pytest.Pytester: |
Contributor
Author
There was a problem hiding this comment.
Inside the pytester fixture they create a new pytest.Pytester instance which inside their constructor overrides these env vars. This overrides the pytester fixture so it runs after it was created, resets the env vars and returns the original instance back.
yury-s
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This made our tests fail after https://developer.chrome.com/blog/remote-debugging-port ended up in Chrome Stable.
Fixes https://github.com/microsoft/playwright-pytest/actions/runs/15280655255/job/42978559948?pr=279#step:5:108