test: do not depend on example.com #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
test/do-not-depend-on-example.cpom
branch
from
9db3d47 to
93d7d30
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR removes the dependency on external domains (example.com and example.org) from tests by implementing a local test server. This improves test reliability by eliminating external network dependencies and ensures consistent test behavior regardless of internet connectivity.
- Introduces a new
TestServerclass that provides local HTTP server functionality - Updates test cases to use the local test server instead of hardcoded external URLs
- Replaces all references to example.com and example.org with dynamically generated localhost URLs
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/conftest.py | Adds TestServer class implementation with HTTP server setup and pytest fixture |
| tests/test_sync.py | Updates synchronous tests to use local test server instead of example.com |
| tests/test_asyncio.py | Updates asynchronous tests to use local test server instead of example.com |
mxschmitt
force-pushed
the
test/do-not-depend-on-example.cpom
branch
from
440ec7c to
331a08d
Compare
Skn0tt
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
example.comturns out to be behaving different in recent weeks - time to switch to our own server.