chore: re-introduce PLAYWRIGHT_SKIP_NAVIGATION_CHECK env var#37993
Closed
ElectroNafta wants to merge 1 commit into
Closed
chore: re-introduce PLAYWRIGHT_SKIP_NAVIGATION_CHECK env var#37993ElectroNafta wants to merge 1 commit into
ElectroNafta wants to merge 1 commit into
Conversation
Contributor
|
Please open an issue describing your issue in detail before submitting PRs. In this issue please provide why you need this envvar, why other solutions not sufficient for you, etc. |
Member
|
I'll close it while we are discussing this in the issue, maybe we need an official support for it |
Author
|
Thanks, I've opened up an issue #38077. 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As stated in the comment, some Electron applications (including ours) rely on PLAYWRIGHT_SKIP_NAVIGATION_CHECK, which was removed in #36283.
The issue is that we intercept certain requests and open them in a separate Electron window. When this happens, Playwright loses context and waits indefinitely for the page to load, even though it never will since the request was intercepted.
This PR re-introduces the environment variable as a means of providing an escape hatch for applications with non-standard navigation handling.
🙏