Skip to content

Conversation

@Francois-Esquire
Copy link
Contributor

Allows to use a different download host per browser, or a single one + default download hosts, preserving the initial behavior.

@aslushnikov
Copy link
Contributor

Hi Mike!

Code itself looks good, thanks.

While we're here, I'd love to use the chance to learn more about your setup. Do you use different artifact storages for different browsers?

@Francois-Esquire
Copy link
Contributor Author

Francois-Esquire commented Jun 9, 2020

Hi Andrey, apologies for the delay in response - glad to hear !

Yeah no problem. In brief as you said, there are different sources to obtain the binaries, which is why it helps to be able to set them individually 😅similar to the current default behavior of playwright when downloading chromium and firefox/webkit. Sorry for being somewhat vague...

@Francois-Esquire
Copy link
Contributor Author

Hey @aslushnikov , any chance you can spare some time to review please 😬

@aslushnikov aslushnikov merged commit 63924d9 into microsoft:master Jun 18, 2020
@arjunattam
Copy link
Contributor

Does this require a docs change? To docs/installation.md perhaps?

@aslushnikov
Copy link
Contributor

Yep, I'm following up rn

@Francois-Esquire Francois-Esquire deleted the feature/allow-multiple-download-hosts branch June 18, 2020 19:12
@Francois-Esquire
Copy link
Contributor Author

Yep, I'm following up rn

@arjun27 that's my bad... I totally forgot about that... Thank you @aslushnikov !!

@arjunattam
Copy link
Contributor

No worries! Really appreciate your contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants