docs: add assertions doc #2585
Merged
docs: add assertions doc #2585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - [Handle requests](./network.md#handle-requests) | ||
| - [Modify requests](./network.md#modify-requests) | ||
| - [Abort requests](./network.md#abort-requests) | ||
| 1. [Assertions](./assertions.md) |
There was a problem hiding this comment.
Assertions and Verification - kind of the same thing?
There was a problem hiding this comment.
Yes, there's an overlap, but I've seen users ask for assertions even after having seen our docs. Planning to remove the "assertion" related bits from the verification doc (like page.$eval). Verification will focus on screenshots, bubbling console logs, network failures, errors.
|
Updated assertions and verification to be more focused. The verifications doc will evolve to cover post-mortem diagnostics. |
pavelfeldman
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.