chore(rpc): implement input, a11y, console #2722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
approved these changes
Jun 26, 2020
|
|
||
| snapshot(options: { interestingOnly?: boolean; root?: ElementHandle } = {}): Promise<types.SerializedAXNode | null> { | ||
| const root = options.root ? options.root._elementChannel : undefined; | ||
| return this._channel.accessibilitySnapshot({ options: { interestingOnly: options.interestingOnly, root } }); |
There was a problem hiding this comment.
Shouldn't the recursive handle->guid unwrapper handle the root?
There was a problem hiding this comment.
I need to go from ElementHandle to ElementHandleChannel here, recursive wrapper goes Channel -> guid
src/rpc/connection.ts
Outdated
| if (prop === 'on') | ||
| return obj.on; | ||
| if (prop === 'once') | ||
| return obj.on; |
|
|
||
| async waitForEvent(params: { event: string }): Promise<any> { | ||
| const result = await this._page.waitForEvent(params.event); | ||
| if (result instanceof ConsoleMessage) |
There was a problem hiding this comment.
Might as well do Request, Response and Frame.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.