chore(rpc): support downloads, dialogs, persistent context #2733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
approved these changes
Jun 26, 2020
| } | ||
|
|
||
| suggestedFilename(): string { | ||
| return this._initializer.suggestedFilename; |
There was a problem hiding this comment.
IIRC, this one is updated dynamically.
| import { Page } from '../../page'; | ||
|
|
||
| export class BrowserContextDispatcher extends Dispatcher<BrowserContextInitializer> implements BrowserContextChannel { | ||
| export class BrowserContextDispatcher extends Dispatcher<BrowserContext, BrowserContextInitializer> implements BrowserContextChannel { |
There was a problem hiding this comment.
Make it Dispatcher<BrowserContextBase...> and use this._object instead of this._context?
There was a problem hiding this comment.
I like this._context more for readability - i don't really need base
src/rpc/server/jsHandleDispatcher.ts
Outdated
| */ | ||
|
|
||
| import * as js from '../../javascript'; | ||
| import { JSHandle } from '../../javascript'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.