Skip to content

Conversation

@playwrightmachine
Copy link
Contributor

@playwrightmachine playwrightmachine commented Sep 25, 2024

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@mxschmitt mxschmitt force-pushed the roll-into-pw-webkit/2083 branch from c746078 to 38a2b23 Compare September 26, 2024 11:21
@mxschmitt mxschmitt marked this pull request as draft September 26, 2024 11:26
@github-actions

This comment has been minimized.

@mxschmitt mxschmitt force-pushed the roll-into-pw-webkit/2083 branch from 38a2b23 to 74af249 Compare September 26, 2024 16:53
@mxschmitt mxschmitt marked this pull request as ready for review September 26, 2024 16:53
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@mxschmitt mxschmitt added CQ1 and removed CQ1 labels Sep 26, 2024
@github-actions

This comment has been minimized.

@mxschmitt mxschmitt added CQ1 and removed CQ1 labels Sep 26, 2024
@mxschmitt mxschmitt force-pushed the roll-into-pw-webkit/2083 branch from 4aa36f9 to 90fc8d9 Compare September 26, 2024 18:56
@mxschmitt mxschmitt added CQ1 and removed CQ1 labels Sep 26, 2024
@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

Test results for "tests others"

2 flaky ⚠️ [electron-api] › electron/electron-tracing.spec.ts:37:5 › should support custom protocol
⚠️ [chromium-library] › library/client-certificates.spec.ts:400:3 › browser › should not hang on tls errors during TLS 1.2 handshake

20715 passed, 534 skipped
✔️✔️✔️

Merge workflow run.

@github-actions
Copy link
Contributor

Test results for "tests 1"

2 flaky ⚠️ [chromium-library] › library/trace-viewer.spec.ts:256:1 › should have network requests
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all

36387 passed, 747 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit 463bd55 into main Sep 26, 2024
@mxschmitt mxschmitt deleted the roll-into-pw-webkit/2083 branch September 26, 2024 19:49
@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

Test results for "tests 2"

2 fatal errors, not part of any test
11 failed
❌ [chromium-page] › page/page-leaks.spec.ts:62:5 › click should not leak
❌ [chromium-page] › page/page-leaks.spec.ts:127:5 › expect should not leak
❌ [chromium-page] › page/page-leaks.spec.ts:159:5 › waitFor should not leak
❌ [chromium-page] › page/page-leaks.spec.ts:94:5 › fill should not leak
❌ [chromium-page] › page/page-leaks.spec.ts:94:5 › fill should not leak
❌ [chromium-library] › library/browsertype-connect.spec.ts:867:7 › run-server › socks proxy › should proxy based on the pattern
❌ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har
❌ [chromium-library] › library/inspector/cli-codegen-java.spec.ts:92:5 › should work with --save-har
❌ [chromium-library] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified
❌ [webkit-codegen-mode-trace] › library/inspector/cli-codegen-3.spec.ts:171:7 › cli codegen › should generate frame locators (4)
❌ [webkit-codegen-mode-trace] › library/inspector/cli-codegen-3.spec.ts:171:7 › cli codegen › should generate frame locators (4)

144 flaky ⚠️ [chromium-page] › page/page-event-request.spec.ts:138:3 › should report navigation requests and responses handled by service worker with routing
⚠️ [chromium-page] › page/page-screenshot.spec.ts:649:5 › page screenshot animations › should stop animations that happen right before screenshot
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1230:3 › should work with connectOverCDP
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:328:5 › launchServer › should throw when used after isConnected returns false
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:681:5 › run-server › should upload large file
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:26:5 › should connect to an existing cdp session
⚠️ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:83:3 › should(not) block third party cookies
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:470:7 › cli codegen › should --save-trace
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1158:1 › should pick locator in iframe
⚠️ [chromium-codegen-mode-trace] › library/inspector/cli-codegen-java.spec.ts:92:5 › should work with --save-har
⚠️ [chromium-codegen-mode-trace] › library/inspector/cli-codegen-python-async.spec.ts:82:5 › should save the codegen output to a file if specified
⚠️ [chromium-library] › library/tap.spec.ts:22:3 › should send all of the correct events @smoke
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:509:7 › cli codegen › should check
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation
⚠️ [chromium-codegen-mode-trace] › library/inspector/cli-codegen-3.spec.ts:616:7 › cli codegen › should consume contextmenu events, despite a custom context menu
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:316:7 › cli codegen › should record open in a new tab with url
⚠️ [chromium-page] › page/page-screenshot.spec.ts:649:5 › page screenshot animations › should stop animations that happen right before screenshot
⚠️ [chromium-library] › library/capabilities.spec.ts:22:3 › SharedArrayBuffer should work @smoke
⚠️ [chromium-library] › library/client-certificates.spec.ts:748:3 › browser › should handle rejected certificate in handshake with HTTP/2
⚠️ [chromium-library] › library/emulation-focus.spec.ts:21:3 › should think that it is focused by default
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:238:7 › cli codegen › should not target selector preview by text regexp
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:384:7 › cli codegen › click should emit events in order
⚠️ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:26:7 › cli codegen › should click locator.first
⚠️ [chromium-library] › library/inspector/console-api.spec.ts:37:3 › should support playwright.$, playwright.$$
⚠️ [chromium-library] › library/inspector/pause.spec.ts:22:3 › should resume when closing inspector
⚠️ [chromium-library] › library/role-utils.spec.ts:104:5 › wpt accname non-manual
⚠️ [chromium-library] › library/route-web-socket.spec.ts:73:9 › no-mock › should work with text message
⚠️ [chromium-library] › library/selector-generator.spec.ts:483:5 › selector generator › should prefer role other input[type]
⚠️ [chromium-library] › library/slowmo.spec.ts:163:5 › slowMo › ElementHandle SlowMo setInputFiles
⚠️ [chromium-library] › library/trace-viewer.spec.ts:314:1 › should filter network requests by url
⚠️ [chromium-library] › library/trace-viewer.spec.ts:822:1 › should highlight target element in shadow dom
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1158:1 › should pick locator in iframe
⚠️ [chromium-library] › library/video.spec.ts:287:5 › screencast › should delete video
⚠️ [chromium-library] › library/video.spec.ts:833:3 › should saveAs video
⚠️ [chromium-page] › page/expect-misc.spec.ts:21:7 › toHaveCount › toHaveCount pass
⚠️ [chromium-page] › page/expect-to-have-text.spec.ts:96:7 › toHaveText with text › pass eventually
⚠️ [chromium-page] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [chromium-page] › page/page-add-locator-handler.spec.ts:260:5 › should work with times: option
⚠️ [chromium-page] › page/page-click-timeout-1.spec.ts:20:3 › should avoid side effects after timeout
⚠️ [chromium-page] › page/page-click.spec.ts:530:3 › trial run should work with short timeout
⚠️ [chromium-page] › page/page-evaluate.spec.ts:509:3 › should transfer 100Mb of data from page to node.js
⚠️ [chromium-page] › page/page-goto.spec.ts:714:3 › should fail when canceled by another navigation
⚠️ [chromium-page] › page/page-network-request.spec.ts:151:3 › should not get preflight CORS requests when intercepting
⚠️ [chromium-page] › page/page-screenshot.spec.ts:895:3 › should throw if screenshot size is too large
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:123:3 › should throw when uploading a file in a directory upload input
⚠️ [chromium-page] › page/queryselector.spec.ts:37:3 › should query existing element with xpath selector
⚠️ [chromium-page] › page/selectors-frame.spec.ts:79:3 › should work for nested iframe (handle)
⚠️ [chromium-codegen-mode-trace] › library/inspector/cli-codegen-1.spec.ts:727:7 › cli codegen › should attribute navigation to click
⚠️ [chromium-codegen-mode-trace] › library/inspector/cli-codegen-3.spec.ts:171:7 › cli codegen › should generate frame locators (4)
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:422:5 › launchServer › should reject waitForEvent before browser.onDisconnect fires
⚠️ [chromium-page] › page/workers.spec.ts:228:3 › should support extra http headers
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation
⚠️ [firefox-library] › library/capabilities.spec.ts:260:3 › requestFullscreen
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:616:7 › cli codegen › should consume contextmenu events, despite a custom context menu
⚠️ [firefox-library] › library/video.spec.ts:381:5 › screencast › should capture navigation
⚠️ [firefox-library] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:331:3 › should emulate media in cross-process iframe
⚠️ [firefox-library] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [firefox-library] › library/browsercontext-locale.spec.ts:118:3 › should be isolated between contexts
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:108:7 › cli codegen › should upload a single file
⚠️ [firefox-library] › library/trace-viewer.spec.ts:1405:1 › should allow showing screenshots instead of snapshots
⚠️ [firefox-library] › library/tracing.spec.ts:290:5 › should overwrite existing file
⚠️ [firefox-library] › library/video.spec.ts:239:5 › screencast › should expose video path
⚠️ [firefox-page] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [firefox-page] › page/page-click.spec.ts:97:3 › should click the 1x1 div
⚠️ [firefox-codegen-mode-trace] › library/inspector/cli-codegen-3.spec.ts:758:7 › cli codegen › should assert value on disabled select
⚠️ [firefox-codegen-mode-trace] › library/inspector/cli-codegen-python-async.spec.ts:147:5 › should work with --save-har
⚠️ [firefox-codegen-mode-trace] › library/inspector/cli-codegen-test.spec.ts:88:5 › should work with --save-har
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:616:7 › cli codegen › should consume contextmenu events, despite a custom context menu
⚠️ [firefox-library] › library/tracing.spec.ts:410:14 › should produce screencast frames scale
⚠️ [firefox-page] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [chromium-library] › library/capabilities.spec.ts:141:3 › should not crash on showDirectoryPicker
⚠️ [chromium-library] › library/browsercontext-events.spec.ts:19:5 › console event should work @smoke
⚠️ [chromium-page] › page/page-screenshot.spec.ts:791:5 › page screenshot animations › should trigger particular events for css transitions
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate
⚠️ [chromium-library] › library/browsercontext-base-url.spec.ts:37:3 › should construct a new URL when a baseURL in browserType.launchPersistentContext is passed to page.goto
⚠️ [chromium-library] › library/browsercontext-proxy.spec.ts:27:3 › should work when passing the proxy only on the context level
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:422:5 › launchServer › should reject waitForEvent before browser.onDisconnect fires
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:479:5 › run-server › should not throw on close after disconnect
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:838:7 › run-server › socks proxy › should proxy local.playwright requests
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:955:3 › launchServer only › should be able to reconnect to a browser 12 times without warnings
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:501:5 › setInputFiles should preserve lastModified timestamp
⚠️ [chromium-library] › library/chromium/launcher.spec.ts:28:3 › should not throw with remote-debugging-port argument
⚠️ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:22:3 › context.cookies() should work @smoke
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should work with --save-har
⚠️ [chromium-library] › library/logger.spec.ts:19:3 › should log @smoke
⚠️ [chromium-library] › library/proxy.spec.ts:63:3 › should work with IP:PORT notion
⚠️ [chromium-library] › library/signals.spec.ts:94:7 › signals › should close the browser on SIGHUP
⚠️ [chromium-codegen-mode-trace] › library/inspector/cli-codegen-1.spec.ts:56:7 › cli codegen › should double click
⚠️ [chromium-library] › library/capabilities.spec.ts:141:3 › should not crash on showDirectoryPicker
⚠️ [chromium-library] › library/fetch-proxy.spec.ts:21:3 › context request should pick up proxy credentials
⚠️ [chromium-codegen-mode-trace] › library/inspector/cli-codegen-3.spec.ts:686:7 › cli codegen › should assert value
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:25:7 › cli codegen › should contain open page
⚠️ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:686:7 › cli codegen › should assert value
⚠️ [chromium-page] › page/page-drag.spec.ts:73:5 › Drag and drop › should work inside iframe
⚠️ [chromium-codegen-mode-trace] › library/inspector/cli-codegen-1.spec.ts:200:7 › cli codegen › should work with TrustedTypes
⚠️ [webkit-library] › library/inspector/pause.spec.ts:126:5 › pause › should step
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:611:7 › cli codegen › should select
⚠️ [webkit-codegen-mode-trace] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har
⚠️ [webkit-page] › page/page-mouse.spec.ts:193:3 › should trigger hover state
⚠️ [webkit-codegen-mode-trace] › library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click
⚠️ [webkit-codegen-mode-trace] › library/inspector/cli-codegen-1.spec.ts:97:7 › cli codegen › should ignore programmatic events
⚠️ [webkit-codegen-mode-trace] › library/inspector/cli-codegen-3.spec.ts:686:7 › cli codegen › should assert value
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:382:7 › cli codegen › should press
⚠️ [webkit-codegen-mode-trace] › library/inspector/cli-codegen-1.spec.ts:56:7 › cli codegen › should double click
⚠️ [webkit-codegen-mode-trace] › library/inspector/cli-codegen-1.spec.ts:462:7 › cli codegen › should record ArrowDown
⚠️ [webkit-codegen-mode-trace] › library/inspector/cli-codegen-3.spec.ts:469:7 › cli codegen › should generate getByPlaceholder
⚠️ [webkit-codegen-mode-trace] › library/inspector/cli-codegen-3.spec.ts:498:7 › cli codegen › should generate getByAltText
⚠️ [webkit-codegen-mode-trace] › library/inspector/cli-codegen-3.spec.ts:556:7 › cli codegen › should generate getByLabel without regex
⚠️ [webkit-codegen-mode-trace] › library/inspector/cli-codegen-3.spec.ts:686:7 › cli codegen › should assert value
⚠️ [webkit-codegen-mode-trace] › library/inspector/cli-codegen-3.spec.ts:733:7 › cli codegen › should assert value on disabled input
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:200:7 › cli codegen › should work with TrustedTypes
⚠️ [webkit-codegen-mode-trace] › library/inspector/cli-codegen-1.spec.ts:117:7 › cli codegen › should click after same-document navigation
⚠️ [webkit-codegen-mode-trace] › library/inspector/cli-codegen-1.spec.ts:147:7 › cli codegen › should make a positioned click on a canvas
⚠️ [webkit-codegen-mode-trace] › library/inspector/cli-codegen-1.spec.ts:238:7 › cli codegen › should not target selector preview by text regexp
⚠️ [webkit-codegen-mode-trace] › library/inspector/cli-codegen-1.spec.ts:299:7 › cli codegen › should fill japanese text
⚠️ [webkit-codegen-mode-trace] › library/inspector/cli-codegen-3.spec.ts:758:7 › cli codegen › should assert value on disabled select
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:382:7 › cli codegen › should press
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:484:7 › cli codegen › should emit single keyup on ArrowDown
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:541:7 › cli codegen › should check a radio button
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:611:7 › cli codegen › should select
⚠️ [webkit-library] › library/inspector/cli-codegen-python.spec.ts:78:5 › should save the codegen output to a file if specified
⚠️ [webkit-library] › library/selector-generator.spec.ts:504:5 › selector generator › should generate exact title when necessary
⚠️ [webkit-codegen-mode-trace] › library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click
⚠️ [webkit-codegen-mode-trace] › library/inspector/cli-codegen-1.spec.ts:200:7 › cli codegen › should work with TrustedTypes
⚠️ [webkit-codegen-mode-trace] › library/inspector/cli-codegen-1.spec.ts:238:7 › cli codegen › should not target selector preview by text regexp
⚠️ [webkit-codegen-mode-trace] › library/inspector/cli-codegen-3.spec.ts:527:7 › cli codegen › should generate getByLabel
⚠️ [webkit-codegen-mode-trace] › library/inspector/cli-codegen-3.spec.ts:556:7 › cli codegen › should generate getByLabel without regex
⚠️ [webkit-codegen-mode-trace] › library/inspector/cli-codegen-3.spec.ts:686:7 › cli codegen › should assert value
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:607:5 › run-server › should save har
⚠️ [webkit-library] › library/tracing.spec.ts:410:14 › should produce screencast frames crop
⚠️ [webkit-library] › library/popup.spec.ts:158:3 › should respect routes from browser context when using window.open
⚠️ [webkit-library] › library/video.spec.ts:581:5 › screencast › should capture static page in persistent context @smoke
⚠️ [webkit-library] › library/video.spec.ts:381:5 › screencast › should capture navigation
⚠️ [webkit-codegen-mode-trace] › library/inspector/cli-codegen-pytest.spec.ts:33:5 › should print the correct context options when using a device and lang

248077 passed, 11577 skipped, 78 did not run
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants