Skip to content

chore: fallback to Google mirror #38573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Skn0tt merged 6 commits into from
Dec 18, 2025
Merged

chore: fallback to Google mirror #38573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
993c693
chore: fallback to Google mirror
Skn0tt Dec 16, 2025
f911c81
simplify
Skn0tt Dec 16, 2025
e331343
fix tests
Skn0tt Dec 16, 2025
86ae89a
fix test
Skn0tt Dec 16, 2025
6c78ada
fix once more
Skn0tt Dec 16, 2025
1855eb9
dont fallback to bucket
Skn0tt Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
108 changes: 65 additions & 43 deletions packages/playwright-core/src/server/registry/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,69 +125,82 @@ const EXECUTABLE_PATHS = {
},
};

type DownloadPaths = Record<HostPlatform, string | undefined>;
type DownloadPathFunction = (params: BrowsersJSONDescriptor) => { path: string, mirrors: string[] };

function cftUrl(suffix: string): DownloadPathFunction {
return ({ browserVersion }) => {
return {
path: `${browserVersion}/${suffix}`,
mirrors: [
'https://cdn.playwright.dev/chrome-for-testing-public',
],
};
};
}

type DownloadPaths = Record<HostPlatform, string | DownloadPathFunction | undefined>;
const DOWNLOAD_PATHS: Record<BrowserName | InternalTool, DownloadPaths> = {
'chromium': {
'<unknown>': undefined,
'ubuntu18.04-x64': undefined,
'ubuntu20.04-x64': 'builds/chromium/%s/chromium-linux.zip',
'ubuntu22.04-x64': 'builds/chromium/%s/chromium-linux.zip',
'ubuntu24.04-x64': 'builds/chromium/%s/chromium-linux.zip',
'ubuntu20.04-x64': cftUrl('linux64/chrome-linux64.zip'),
'ubuntu22.04-x64': cftUrl('linux64/chrome-linux64.zip'),
'ubuntu24.04-x64': cftUrl('linux64/chrome-linux64.zip'),
'ubuntu18.04-arm64': undefined,
'ubuntu20.04-arm64': 'builds/chromium/%s/chromium-linux-arm64.zip',
'ubuntu22.04-arm64': 'builds/chromium/%s/chromium-linux-arm64.zip',
'ubuntu24.04-arm64': 'builds/chromium/%s/chromium-linux-arm64.zip',
'debian11-x64': 'builds/chromium/%s/chromium-linux.zip',
'debian11-x64': cftUrl('linux64/chrome-linux64.zip'),
'debian11-arm64': 'builds/chromium/%s/chromium-linux-arm64.zip',
'debian12-x64': 'builds/chromium/%s/chromium-linux.zip',
'debian12-x64': cftUrl('linux64/chrome-linux64.zip'),
'debian12-arm64': 'builds/chromium/%s/chromium-linux-arm64.zip',
'debian13-x64': 'builds/chromium/%s/chromium-linux.zip',
'debian13-x64': cftUrl('linux64/chrome-linux64.zip'),
'debian13-arm64': 'builds/chromium/%s/chromium-linux-arm64.zip',
'mac10.13': 'builds/chromium/%s/chromium-mac.zip',
'mac10.14': 'builds/chromium/%s/chromium-mac.zip',
'mac10.15': 'builds/chromium/%s/chromium-mac.zip',
'mac11': 'builds/chromium/%s/chromium-mac.zip',
'mac11-arm64': 'builds/chromium/%s/chromium-mac-arm64.zip',
'mac12': 'builds/chromium/%s/chromium-mac.zip',
'mac12-arm64': 'builds/chromium/%s/chromium-mac-arm64.zip',
'mac13': 'builds/chromium/%s/chromium-mac.zip',
'mac13-arm64': 'builds/chromium/%s/chromium-mac-arm64.zip',
'mac14': 'builds/chromium/%s/chromium-mac.zip',
'mac14-arm64': 'builds/chromium/%s/chromium-mac-arm64.zip',
'mac15': 'builds/chromium/%s/chromium-mac.zip',
'mac15-arm64': 'builds/chromium/%s/chromium-mac-arm64.zip',
'win64': 'builds/chromium/%s/chromium-win64.zip',
'mac10.13': cftUrl('mac-x64/chrome-mac-x64.zip'),
'mac10.14': cftUrl('mac-x64/chrome-mac-x64.zip'),
'mac10.15': cftUrl('mac-x64/chrome-mac-x64.zip'),
'mac11': cftUrl('mac-x64/chrome-mac-x64.zip'),
'mac11-arm64': cftUrl('mac-arm64/chrome-mac-arm64.zip'),
'mac12': cftUrl('mac-x64/chrome-mac-x64.zip'),
'mac12-arm64': cftUrl('mac-arm64/chrome-mac-arm64.zip'),
'mac13': cftUrl('mac-x64/chrome-mac-x64.zip'),
'mac13-arm64': cftUrl('mac-arm64/chrome-mac-arm64.zip'),
'mac14': cftUrl('mac-x64/chrome-mac-x64.zip'),
'mac14-arm64': cftUrl('mac-arm64/chrome-mac-arm64.zip'),
'mac15': cftUrl('mac-x64/chrome-mac-x64.zip'),
'mac15-arm64': cftUrl('mac-arm64/chrome-mac-arm64.zip'),
'win64': cftUrl('win64/chrome-win64.zip'),
},
'chromium-headless-shell': {
'<unknown>': undefined,
'ubuntu18.04-x64': undefined,
'ubuntu20.04-x64': 'builds/chromium/%s/chromium-headless-shell-linux.zip',
'ubuntu22.04-x64': 'builds/chromium/%s/chromium-headless-shell-linux.zip',
'ubuntu24.04-x64': 'builds/chromium/%s/chromium-headless-shell-linux.zip',
'ubuntu20.04-x64': cftUrl('linux64/chrome-headless-shell-linux64.zip'),
'ubuntu22.04-x64': cftUrl('linux64/chrome-headless-shell-linux64.zip'),
'ubuntu24.04-x64': cftUrl('linux64/chrome-headless-shell-linux64.zip'),
'ubuntu18.04-arm64': undefined,
'ubuntu20.04-arm64': 'builds/chromium/%s/chromium-headless-shell-linux-arm64.zip',
'ubuntu22.04-arm64': 'builds/chromium/%s/chromium-headless-shell-linux-arm64.zip',
'ubuntu24.04-arm64': 'builds/chromium/%s/chromium-headless-shell-linux-arm64.zip',
'debian11-x64': 'builds/chromium/%s/chromium-headless-shell-linux.zip',
'debian11-x64': cftUrl('linux64/chrome-headless-shell-linux64.zip'),
'debian11-arm64': 'builds/chromium/%s/chromium-headless-shell-linux-arm64.zip',
'debian12-x64': 'builds/chromium/%s/chromium-headless-shell-linux.zip',
'debian12-x64': cftUrl('linux64/chrome-headless-shell-linux64.zip'),
'debian12-arm64': 'builds/chromium/%s/chromium-headless-shell-linux-arm64.zip',
'debian13-x64': 'builds/chromium/%s/chromium-headless-shell-linux.zip',
'debian13-x64': cftUrl('linux64/chrome-headless-shell-linux64.zip'),
'debian13-arm64': 'builds/chromium/%s/chromium-headless-shell-linux-arm64.zip',
'mac10.13': undefined,
'mac10.14': undefined,
'mac10.15': undefined,
'mac11': 'builds/chromium/%s/chromium-headless-shell-mac.zip',
'mac11-arm64': 'builds/chromium/%s/chromium-headless-shell-mac-arm64.zip',
'mac12': 'builds/chromium/%s/chromium-headless-shell-mac.zip',
'mac12-arm64': 'builds/chromium/%s/chromium-headless-shell-mac-arm64.zip',
'mac13': 'builds/chromium/%s/chromium-headless-shell-mac.zip',
'mac13-arm64': 'builds/chromium/%s/chromium-headless-shell-mac-arm64.zip',
'mac14': 'builds/chromium/%s/chromium-headless-shell-mac.zip',
'mac14-arm64': 'builds/chromium/%s/chromium-headless-shell-mac-arm64.zip',
'mac15': 'builds/chromium/%s/chromium-headless-shell-mac.zip',
'mac15-arm64': 'builds/chromium/%s/chromium-headless-shell-mac-arm64.zip',
'win64': 'builds/chromium/%s/chromium-headless-shell-win64.zip',
'mac11': cftUrl('mac-x64/chrome-headless-shell-mac-x64.zip'),
'mac11-arm64': cftUrl('mac-arm64/chrome-headless-shell-mac-arm64.zip'),
'mac12': cftUrl('mac-x64/chrome-headless-shell-mac-x64.zip'),
'mac12-arm64': cftUrl('mac-arm64/chrome-headless-shell-mac-arm64.zip'),
'mac13': cftUrl('mac-x64/chrome-headless-shell-mac-x64.zip'),
'mac13-arm64': cftUrl('mac-arm64/chrome-headless-shell-mac-arm64.zip'),
'mac14': cftUrl('mac-x64/chrome-headless-shell-mac-x64.zip'),
'mac14-arm64': cftUrl('mac-arm64/chrome-headless-shell-mac-arm64.zip'),
'mac15': cftUrl('mac-x64/chrome-headless-shell-mac-x64.zip'),
'mac15-arm64': cftUrl('mac-arm64/chrome-headless-shell-mac-arm64.zip'),
'win64': cftUrl('win64/chrome-headless-shell-win64.zip'),
},
'chromium-tip-of-tree': {
'<unknown>': undefined,
Expand Down Expand Up @@ -1216,12 +1229,20 @@ export class Registry {

private _downloadURLs(descriptor: BrowsersJSONDescriptor): string[] {
const paths = (DOWNLOAD_PATHS as any)[descriptor.name];
const downloadPathTemplate: string|undefined = paths[hostPlatform] || paths['<unknown>'];
const downloadPathTemplate: string|DownloadPathFunction|undefined = paths[hostPlatform] || paths['<unknown>'];
if (!downloadPathTemplate)
return [];
const downloadPath = util.format(downloadPathTemplate, descriptor.revision);
let downloadPath: string;
let mirrors: string[];
if (typeof downloadPathTemplate === 'function') {
const result = downloadPathTemplate(descriptor);
downloadPath = result.path;
mirrors = result.mirrors;
} else {
downloadPath = util.format(downloadPathTemplate, descriptor.revision);
mirrors = PLAYWRIGHT_CDN_MIRRORS;
}

let downloadURLs = PLAYWRIGHT_CDN_MIRRORS.map(mirror => `${mirror}/${downloadPath}`) ;
let downloadHostEnv;
if (descriptor.name.startsWith('chromium'))
downloadHostEnv = 'PLAYWRIGHT_CHROMIUM_DOWNLOAD_HOST';
Expand All @@ -1232,8 +1253,9 @@ export class Registry {

const customHostOverride = (downloadHostEnv && getFromENV(downloadHostEnv)) || getFromENV('PLAYWRIGHT_DOWNLOAD_HOST');
if (customHostOverride)
downloadURLs = [`${customHostOverride}/${downloadPath}`];
return downloadURLs;
mirrors = [customHostOverride];

return mirrors.map(mirror => `${mirror}/${downloadPath}`);
}

private async _downloadExecutable(descriptor: BrowsersJSONDescriptor, executablePath?: string) {
Expand Down
2 changes: 1 addition & 1 deletion tests/installation/playwright-cdn.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ for (const cdn of CDNS) {
expect(result).toHaveLoggedSoftwareDownload(['chromium', 'chromium-headless-shell', 'ffmpeg', 'firefox', 'webkit', ...extraInstalledSoftware]);
await checkInstalledSoftwareOnDisk((['chromium', 'chromium-headless-shell', 'ffmpeg', 'firefox', 'webkit', ...extraInstalledSoftware]));
const dls = parsedDownloads(result);
for (const software of ['chromium', 'ffmpeg', 'firefox', 'webkit'])
Copy link
Member

@yury-s yury-s Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should still be present on linux-arm

Copy link
Member Author

@Skn0tt Skn0tt Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true, but afaik we don't test on linux-arm

for (const software of ['ffmpeg', 'firefox', 'webkit'])
expect(dls).toContainEqual({ status: 200, name: software, url: expect.stringContaining(cdn) });
await exec('node sanity.js playwright chromium firefox webkit');
await exec('node esm-playwright.mjs');
Expand Down
6 changes: 5 additions & 1 deletion tests/installation/playwright-cli-install-should-work.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,11 @@ test('install command should work with mirror that uses chunked encoding', async
await exec('npm i playwright');
const server = http.createServer(async (req, res) => {
try {
const upstream = await fetch('https://cdn.playwright.dev/dbazure/download/playwright' + req.url);
const upstream = await fetch(
req.url.startsWith('/builds/')
Copy link
Member

@yury-s yury-s Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment

? 'https://cdn.playwright.dev/dbazure/download/playwright' + req.url
: 'https://cdn.playwright.dev/chrome-for-testing-public' + req.url
);
const headers = new Headers(upstream.headers);
headers.delete('content-length');
res.writeHead(upstream.status, Object.fromEntries(headers));
Expand Down
Loading