Skip to content

[Feature] allow custom args for ffmpeg in VideoRecorder.ts #6473

@ldenoue

Description

@ldenoue

https://github.com/microsoft/playwright/blob/master/src/server/chromium/videoRecorder.ts#L90

videoRecorder uses ffmpeg to generate the videos from incoming JPEG frames.

It uses good params to feed FFMPEG, but I would love to be able to pass my own params.
E.g. instead of outputting to a .webm file, we could transcode to H264 and AAC and feed to an RTMP server.

Do you think others might benefit from this as well?
The ability to customize the video encoding parameters seems interesting in general: some people might want to add custom text overlays for example, or change the frame rate, etc.
@pavelfeldman already changed these parameters several times in previous commits. Letting users change them to arbitrary args would be useful.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions