Skip to content

Commit 7c88df4

Browse files
committed
Fix tests
1 parent 1ffa58c commit 7c88df4

File tree

4 files changed

+9
-18
lines changed

4 files changed

+9
-18
lines changed

crates/pet-poetry/src/lib.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33

44
use env_variables::EnvVariables;
55
use environment_locations::list_environments;
6+
use log::trace;
67
use manager::PoetryManager;
78
use pet_core::{
89
env::PythonEnv,
@@ -69,6 +70,7 @@ impl Poetry {
6970
self.poetry_executable.lock().unwrap().clone(),
7071
&self.env_vars,
7172
);
73+
trace!("Poetry Manager {:?}", manager);
7274
let mut result = LocatorResult {
7375
managers: vec![],
7476
environments: vec![],

crates/pet-pyenv/src/lib.rs

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ use std::{
1313

1414
use env_variables::EnvVariables;
1515
use environments::{get_generic_python_environment, get_virtual_env_environment};
16+
use log::trace;
1617
use manager::PyEnvInfo;
1718
use pet_conda::{utils::is_conda_env, CondaLocator};
1819
use pet_core::{
@@ -33,7 +34,6 @@ mod manager;
3334
pub struct PyEnv {
3435
pub env_vars: EnvVariables,
3536
pub conda_locator: Arc<dyn CondaLocator>,
36-
found_pyenv: AtomicBool,
3737
manager: Arc<Mutex<Option<EnvManager>>>,
3838
versions_dir: Arc<Mutex<Option<PathBuf>>>,
3939
}
@@ -44,24 +44,22 @@ impl PyEnv {
4444
conda_locator: Arc<dyn CondaLocator>,
4545
) -> impl Locator {
4646
PyEnv {
47-
found_pyenv: AtomicBool::new(false),
4847
env_vars: EnvVariables::from(environment),
4948
conda_locator,
5049
manager: Arc::new(Mutex::new(None)),
5150
versions_dir: Arc::new(Mutex::new(None)),
5251
}
5352
}
5453
fn clear(&self) {
55-
self.found_pyenv
56-
.store(false, std::sync::atomic::Ordering::Relaxed);
5754
self.manager.lock().unwrap().take();
5855
self.versions_dir.lock().unwrap().take();
5956
}
6057
fn get_manager_versions_dir(&self) -> (Option<EnvManager>, Option<PathBuf>) {
6158
let mut managers = self.manager.lock().unwrap();
6259
let mut versions = self.versions_dir.lock().unwrap();
63-
if !self.found_pyenv.load(Ordering::Relaxed) && (managers.is_none() || versions.is_none()) {
60+
if managers.is_none() || versions.is_none() {
6461
let pyenv_info = PyEnvInfo::from(&self.env_vars);
62+
trace!("PyEnv Info {:?}", pyenv_info);
6563
if let Some(ref exe) = pyenv_info.exe {
6664
let version = pyenv_info.version.clone();
6765
let manager = EnvManager::new(exe.clone(), EnvManagerType::Pyenv, version);
@@ -74,9 +72,8 @@ impl PyEnv {
7472
} else {
7573
versions.take();
7674
}
77-
self.found_pyenv.store(true, Ordering::Relaxed);
7875
}
79-
76+
trace!("PyEnv Manager {:?} and versions {:?}", managers, versions);
8077
(managers.clone(), versions.clone())
8178
}
8279
}
@@ -164,6 +161,8 @@ impl Locator for PyEnv {
164161
}
165162
}
166163
});
164+
} else {
165+
trace!("PyEnv versions directory not found");
167166
}
168167
}
169168
}

crates/pet-python-utils/src/fs_cache.rs

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -119,15 +119,4 @@ mod tests {
119119
"c3694bfb39d7065b"
120120
);
121121
}
122-
123-
#[test]
124-
#[cfg(windows)]
125-
fn test_hash_generation_upper_case() {
126-
assert_eq!(
127-
generate_hash(&PathBuf::from(
128-
"C:\\TEMP\\POETRY-FOLDERS\\demo-project1".to_string(),
129-
)),
130-
"c3694bfb39d7065b"
131-
);
132-
}
133122
}

crates/pet/tests/ci_test.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -226,6 +226,7 @@ fn check_if_pyenv_virtualenv_exists() {
226226
let environment = EnvironmentApi::new();
227227
let conda_locator = Arc::new(Conda::from(&environment));
228228
let poetry_locator = Arc::new(Poetry::from(&environment));
229+
trace!("Checking for pyenv-virtualenv");
229230

230231
find_and_report_envs(
231232
&CacheReporter::new(reporter.clone()),

0 commit comments

Comments
 (0)