This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Make sure we do not try and create specific type for non-generics #1316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 11, 2019 14:05
Do not create specific types for non-generics
MikhailArkhipov
commented
Jul 11, 2019
| foreach (var m in members) { | ||
| switch (m.Value) { | ||
| case IPythonTemplateType tt: { | ||
| case IPythonTemplateType tt when tt.IsGeneric(): { |
Author
There was a problem hiding this comment.
Missing when, see similar care below
MikhailArkhipov
commented
Jul 11, 2019
|
|
||
| // For still undefined parameters try matching passed types in order | ||
| for (var i = 0; i < args.Arguments.Count; i++) { | ||
| for (int i = 0, gtIndex = 0; i < args.Arguments.Count; i++) { |
Author
There was a problem hiding this comment.
parameter index does not always equal generic parameter index (consider self)
jakebailey
approved these changes
Jul 11, 2019
Member
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
LGTM if the the full suite ends up passing.
jakebailey
pushed a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
…crosoft#1316) * Test * Cache specific types Do not create specific types for non-generics
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1291
self.