Make the DNN model compatible with CPU & Update the Estimator doc #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bxdd
added
documentation
you-n-g
reviewed
Oct 6, 2020
| - If region == ``qlib.config.REG_CN``, 'qlib' will be initialized in US-stock mode. | ||
| - If region == ``qlib.config.REG_US``, 'qlib' will be initialized in china-stock mode. | ||
| - If `region` == "us", ``Qlib`` will be initialized in US-stock mode. | ||
| - If `region` == "cn", ``Qlib`` will be initialized in china-stock mode. |
Collaborator
There was a problem hiding this comment.
The concerete value in is upper case here
I think change all of them to lower case will be better
| input_dim, | ||
| output_dim, | ||
| layers=(256, 256, 128), | ||
| layers=(256, 512, 768, 1024, 768, 512, 256, 128, 64), |
Collaborator
There was a problem hiding this comment.
Will the change of NN structure affects the performance greatly?
qlib/contrib/model/pytorch_nn.py
Outdated
|
|
||
| self._fitted = False | ||
| self.dnn_model.cuda() | ||
|
|
Collaborator
There was a problem hiding this comment.
@Derek-Wds It seems that we have run the pep8 checker but the errors are not raised.
We use black with max line width set to 120 as our pep8 checker.
| layers = [input_dim] + list(layers) | ||
| dnn_layers = [] | ||
| drop_input = nn.Dropout(0.1) | ||
| drop_input = nn.Dropout(0.05) |
Collaborator
There was a problem hiding this comment.
Will these changes of structure affect the NN performance greatly?
you-n-g
pushed a commit
to you-n-g/qlib
that referenced
this pull request
Aug 16, 2025
Update Experiment2Feedback interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr aims to make the DNN model compatible with CPU and update the
Estimatordoc.Motivation and Context
The pr is related to #47
How Has This Been Tested?
pytest qlib/tests/test_all_pipeline.pyunder upper directory ofqlib.Types of changes