Fix re about provider_uri & Fix 'exit not defined' error in ipython #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
you-n-g
reviewed
Nov 11, 2020
qlib/config.py
Outdated
| # Windows path is "C:\\" | ||
| if rm is None or Path(self["provider_uri"]).exists(): | ||
| return QlibConfig.LOCAL_URI | ||
| if win_rm is None: |
Collaborator
There was a problem hiding this comment.
The logic could be simpler
win = re.match("^[a-zA-Z]:.*", self["provider_uri"]) is not None # such as 'C:\\data', 'D:'
nfs_or_win = re.match("^[^/]+:.+", self["provider_uri"]) is not None # such as 'host:/data/' (User may define short hostname by themselves)
if nfs_or_win and not win:
return QlibConfig.NFS_URI
else:
return QlibConfig.LOCAL_URI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix re about provider_uri & fix 'exit not defined' error in ipython
Types of changes