This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Implements #70: Provide Q# call stack information with source locations in case Q# program fails #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avasch01
reviewed
Oct 30, 2019
avasch01
reviewed
Oct 30, 2019
bettinaheim
reviewed
Nov 12, 2019
anpaz
suggested changes
Nov 20, 2019
Member
anpaz
left a comment
anpaz
left a comment
There was a problem hiding this comment.
Overall looks good. I do have some comments but nothing major. Thanks!
anpaz
approved these changes
Nov 21, 2019
| /// https://github.com/dotnet/designs/blob/master/accepted/diagnostics/source-link.md#source-link-json-schema | ||
| /// </summary> | ||
| [Serializable] | ||
| public class SourceLinkPathRemapping |
Member
There was a problem hiding this comment.
Wondering if this should just be called SourceLink or SourceLinkData or SourceLinkInfo.
| #region Stack trace collection support | ||
| private StackTraceCollector stackTraceCollector = null; | ||
|
|
||
| public void EnableStackTrace() |
Member
There was a problem hiding this comment.
I would like to see if we can instead enabling by default and just disabling it explicitly.
…crosoft/qsharp-runtime into vadym-kl/70-qsharp-call-stack
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following changes:
Microsoft.Quantum.Simulation.CommonStackTrace.cs: Q# specificStackFrameandStackTraceCollectorthat listens toSimulatorBaseevents to keep track of stack trace.PortablePDBReader.csto access SourceLink and source code information from PortablePDBs.SimulatorBase.cs: ModifiedRunmethod to dump Q# stack trace in case of unhandled exception, addedEnableStackTrace()method andCallStackproperty.Microsoft.Quantum.Simulation.Common.csproj: added dependency onSystem.Reflection.Metadatato read PortablePDBs.Microsoft.Quantum.Simulation.CoreIWrappedOperationinterface, so there is an easy uniform way to get to operation being wrapped byAdjointedOperation,ControlledOperationand other similar wrappers. This is necessary to get to the attributes that contain source file and line numbers ofICallables.This affects several files in
src/Simulation/Core/Genericsandsrc/Simulation/Core/Operations.UnwrapCallableto assist with unwrapping usingIWrappedOperationinterface.Microsoft.Quantum.QsCompiler.CsharpGenerationIncludes @bettinaheim's fix in
src/Simulation/CsharpGeneration/SimulationCode.fsto use base one line numbers uniformly in all C# generated code; inside#linedirectives and inSourceLocationattributes.Microsoft.Quantum.Simulation.Simulators.Tests