-
Notifications
You must be signed in to change notification settings - Fork 52
adding changes to support horizontal scroll with keyboard #660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s). |
const handleHorizontalScrollViewKeyDown = (e: any) => { | ||
if (!horizontalScrollViewRef.current) return; | ||
|
||
const scrollAmount = 50; // Amount to scroll in pixels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not hardcode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed the hardcoding
/azp run |
Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
[React Native Gallery Preview]: User is unable to access the 'A Horizontal Scrollview scroll bar using keyboard
Why
[React Native Gallery Preview]: User is unable to access the 'A Horizontal Scrollview scroll bar using keyboard
Resolves [https://github.com/https://github.com//issues/651]
What
[React Native Gallery Preview]: User is unable to access the 'A Horizontal Scrollview scroll bar using keyboard
Screenshots
Before
scrollbar_horizontal_before.mp4
After
keyboard_after.mp4
Microsoft Reviewers: Open in CodeFlow