Skip to content

Conversation

Saadnajmi
Copy link
Collaborator

Backport #1132 to 0.64-stable

…ers (microsoft#1132)

* Only pass height or width if needed

* fix typo

* Update RCTScrollContentLocalData.h
@Saadnajmi Saadnajmi requested a review from alloy as a code owner April 23, 2022 00:30
@Saadnajmi Saadnajmi requested a review from a team April 23, 2022 00:30
@pull-bot
Copy link

Fails
🚫

❔ This pull request needs a description.

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 75c61cf

@Saadnajmi
Copy link
Collaborator Author

Closing because it looks like the 0.64 branch is broken, and I'd rather just push updating FURN to 0.66 than support this version any longer

@Saadnajmi Saadnajmi closed this Apr 25, 2022
@Saadnajmi Saadnajmi deleted the scrollview-64 branch April 25, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants