Enable .podspec files for Fabric #1460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophpurrer
commented
Oct 27, 2022
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2022
When enabling the Fabric podspec files microsoft#1460 we can't even compile rn-iOS. Here are the necessary fixes
4 tasks
I should have deleted those in main? |
|
Higher level question: I wonder if we should do this work on a separate branch from main called "fabric" or so, so we can iterate on it separately from main, and merge the entire branch in once we're happy with the state. |
I must have been on a 0.68 branch when creating this PR. |
|
I think this a good strategy. |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 27, 2022
When enabling the Fabric podspec files microsoft#1460 we can't even compile rn-iOS. Here are the necessary fixes
Right now running: bundle install && USE_FABRIC=1 bundle exec pod install in packages/rn-tester fails as certain targets are not enabled for macOS 10.15 TEST: Pod installation complete! There are 69 dependencies from the Podfile and 57 total pods installed. [!] The Podfile contains framework or static library targets (iosDeviceBuild, iosSimulatorBuild, macOSBuild), for which the Podfile does not contain host targets (targets which embed the framework). If this project is for doing framework development, you can ignore this message. Otherwise, add a target to the Podfile that embeds these frameworks to make this message go away (e.g. a test target).
christophpurrer
force-pushed
the
fabricPodSpec
branch
from
0d4d6ab to
4a20d30
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 31, 2022
When enabling the Fabric podspec files microsoft#1460 we can't even compile rn-iOS. Here are the necessary fixes
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 31, 2022
When enabling the Fabric podspec files microsoft#1460 we can't even compile rn-iOS. Here are the necessary fixes
Saadnajmi
approved these changes
Nov 1, 2022
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 1, 2022
When enabling the Fabric podspec files microsoft#1460 we can't even compile rn-iOS. Here is the 1st of 2 necessary fixes
Saadnajmi
pushed a commit
that referenced
this pull request
Nov 1, 2022
When enabling the Fabric podspec files #1460 we can't even compile rn-iOS. Here is the 1st of 2 necessary fixes
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
Right now running: bundle install && USE_FABRIC=1 bundle exec pod install in packages/rn-tester fails as certain targets are not enabled for macOS 10.15 TEST: Pod installation complete! There are 69 dependencies from the Podfile and 57 total pods installed. [!] The Podfile contains framework or static library targets (iosDeviceBuild, iosSimulatorBuild, macOSBuild), for which the Podfile does not contain host targets (targets which embed the framework). If this project is for doing framework development, you can ignore this message. Otherwise, add a target to the Podfile that embeds these frameworks to make this message go away (e.g. a test target).
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
When enabling the Fabric podspec files microsoft#1460 we can't even compile rn-iOS. Here is the 1st of 2 necessary fixes
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
Right now running: bundle install && USE_FABRIC=1 bundle exec pod install in packages/rn-tester fails as certain targets are not enabled for macOS 10.15 TEST: Pod installation complete! There are 69 dependencies from the Podfile and 57 total pods installed. [!] The Podfile contains framework or static library targets (iosDeviceBuild, iosSimulatorBuild, macOSBuild), for which the Podfile does not contain host targets (targets which embed the framework). If this project is for doing framework development, you can ignore this message. Otherwise, add a target to the Podfile that embeds these frameworks to make this message go away (e.g. a test target).
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
When enabling the Fabric podspec files microsoft#1460 we can't even compile rn-iOS. Here is the 1st of 2 necessary fixes
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
Right now running: bundle install && USE_FABRIC=1 bundle exec pod install in packages/rn-tester fails as certain targets are not enabled for macOS 10.15 TEST: Pod installation complete! There are 69 dependencies from the Podfile and 57 total pods installed. [!] The Podfile contains framework or static library targets (iosDeviceBuild, iosSimulatorBuild, macOSBuild), for which the Podfile does not contain host targets (targets which embed the framework). If this project is for doing framework development, you can ignore this message. Otherwise, add a target to the Podfile that embeds these frameworks to make this message go away (e.g. a test target).
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
When enabling the Fabric podspec files microsoft#1460 we can't even compile rn-iOS. Here is the 1st of 2 necessary fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Right now running:
bundle install && USE_FABRIC=1 bundle exec pod install
in packages/rn-tester fails as certain targets are not enabled for macOS 10.15
This fixes the .podspec files - Fabric related code does not compile - but at least we can build rn-iOS with Fabric now.
ATTENTION, ATTENTION
If you ever build with Fabric enabled and then switch to a non Fabric workspace > there is a huge change the Xcode will produce funky compile errors.
Follow https://reactnative.dev/docs/the-new-architecture/use-app-template#troubleshooting
Changelog
[macOS] [Fixed] - Enable .podspec files for Fabric
Test Plan
Pod installation complete! There are 69 dependencies from the Podfile and 57 total pods installed.
[!] The Podfile contains framework or static library targets (iosDeviceBuild, iosSimulatorBuild, macOSBuild), for which the Podfile does not contain host targets (targets which embed the framework). If this project is for doing framework development, you can ignore this message. Otherwise, add a target to the Podfile that embeds these frameworks to make this message go away (e.g. a test target).