Skip to content

Conversation

christophpurrer
Copy link

@christophpurrer christophpurrer commented Oct 27, 2022

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

When enabling the Fabric podspec files
#1460 we can't even compile rn-iOS.

Here is the 1st of 2 necessary fixes

Changelog

[iOS] [Fixed] - Fix compile errors when building with Fabric on rn-iOS

Test Plan

Screen.Recording.2022-10-27.at.10.48.04.PM.mov

@christophpurrer christophpurrer requested a review from a team as a code owner October 27, 2022 20:49
@christophpurrer
Copy link
Author

christophpurrer commented Nov 1, 2022

@Saadnajmi > I had 2nd thoughts and I think I will need to make a more generic change here.

@Saadnajmi
Copy link
Collaborator

This change also reminds me we should have some pipeline jobs testing if Fabric iOS builds..

When enabling the Fabric podspec files
microsoft#1460
we can't even compile rn-iOS.

Here is the 1st of 2 necessary fixes
@christophpurrer
Copy link
Author

This change also reminds me we should have some pipeline jobs testing if Fabric iOS builds..

That would be great

@christophpurrer
Copy link
Author

@Saadnajmi > This PR can be merged now ;-)
I am making another PR for the scaleFactor problem

@Saadnajmi Saadnajmi enabled auto-merge (squash) November 1, 2022 21:35
@Saadnajmi Saadnajmi merged commit 3d8a3a0 into microsoft:main Nov 1, 2022
shwanton pushed a commit to shwanton/react-native-macos that referenced this pull request Feb 13, 2023
When enabling the Fabric podspec files
microsoft#1460
we can't even compile rn-iOS.

Here is the 1st of 2 necessary fixes
shwanton pushed a commit to shwanton/react-native-macos that referenced this pull request Mar 10, 2023
When enabling the Fabric podspec files
microsoft#1460
we can't even compile rn-iOS.

Here is the 1st of 2 necessary fixes
shwanton pushed a commit to shwanton/react-native-macos that referenced this pull request Mar 10, 2023
When enabling the Fabric podspec files
microsoft#1460
we can't even compile rn-iOS.

Here is the 1st of 2 necessary fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants