forked from facebook/react-native
-
Notifications
You must be signed in to change notification settings - Fork 149
Fix compile errors when building with Fabric on rn-iOS #1461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophpurrer
commented
Oct 27, 2022
Saadnajmi
reviewed
Oct 27, 2022
React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm
Outdated
Show resolved
Hide resolved
d6ff0d9
to
d9d6aca
Compare
Saadnajmi
reviewed
Oct 30, 2022
React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm
Outdated
Show resolved
Hide resolved
Saadnajmi
approved these changes
Nov 1, 2022
@Saadnajmi > I had 2nd thoughts and I think I will need to make a more generic change here. |
This change also reminds me we should have some pipeline jobs testing if Fabric iOS builds.. |
When enabling the Fabric podspec files microsoft#1460 we can't even compile rn-iOS. Here is the 1st of 2 necessary fixes
d9d6aca
to
c457dda
Compare
That would be great |
@Saadnajmi > This PR can be merged now ;-) |
Saadnajmi
approved these changes
Nov 1, 2022
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
When enabling the Fabric podspec files microsoft#1460 we can't even compile rn-iOS. Here is the 1st of 2 necessary fixes
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
When enabling the Fabric podspec files microsoft#1460 we can't even compile rn-iOS. Here is the 1st of 2 necessary fixes
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
When enabling the Fabric podspec files microsoft#1460 we can't even compile rn-iOS. Here is the 1st of 2 necessary fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
When enabling the Fabric podspec files
#1460 we can't even compile rn-iOS.
Here is the 1st of 2 necessary fixes
Changelog
[iOS] [Fixed] - Fix compile errors when building with Fabric on rn-iOS
Test Plan
Screen.Recording.2022-10-27.at.10.48.04.PM.mov