Cherry-pick: Use std::optional instead of butter::optional #1498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophpurrer
force-pushed
the
butter
branch
from
b168bf1 to
df589b7
Compare
Summary: changelog: Use std::optional instead of butter::optional Reviewed By: fkgozali Differential Revision: D33352680 fbshipit-source-id: 45a53fec181a6ffb6218909bc23348f7c9f21ec4 # Conflicts: # ReactAndroid/src/main/java/com/facebook/react/fabric/jni/viewPropConversions.h # ReactCommon/react/renderer/components/view/ViewProps.h # ReactCommon/react/renderer/components/view/primitives.h # ReactCommon/react/renderer/components/view/propsConversions.h # ReactCommon/react/renderer/scheduler/Scheduler.cpp
christophpurrer
force-pushed
the
butter
branch
from
df589b7 to
938f0c4
Compare
Saadnajmi
approved these changes
Nov 15, 2022
rasaha91
approved these changes
Nov 15, 2022
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 16, 2022
These changes were 'missed' in microsoft#1498
4 tasks
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 16, 2022
These changes were 'missed' in microsoft#1498
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 16, 2022
These changes were 'missed' in microsoft#1498
Saadnajmi
pushed a commit
that referenced
this pull request
Nov 16, 2022
These changes were 'missed' in #1498
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 12, 2023
Due to an early cherry-pick from a more recent facebook/react-native version > microsoft#1498 this broke. In microsoft#1498 I must have only build for rn-iOS + Paper. I think we need a CircleCI job now for rn-iOS + Fabric Here is the fix. - std::optional's function signature is has_value() - where as folly::Optional used hasValue() In packages/rn-tester I ran: ``` USE_FABRIC=1 pod install ``` And then build and launched the app
4 tasks
Saadnajmi
pushed a commit
that referenced
this pull request
Jan 12, 2023
…ic (#1634) Due to an early cherry-pick from a more recent facebook/react-native version > #1498 this broke. In #1498 I must have only build for rn-iOS + Paper. I think we need a CircleCI job now for rn-iOS + Fabric Here is the fix. - std::optional's function signature is has_value() - where as folly::Optional used hasValue() In packages/rn-tester I ran: ``` USE_FABRIC=1 pod install ``` And then build and launched the app
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
Summary: changelog: Use std::optional instead of butter::optional Reviewed By: fkgozali Differential Revision: D33352680 fbshipit-source-id: 45a53fec181a6ffb6218909bc23348f7c9f21ec4 # Conflicts: # ReactAndroid/src/main/java/com/facebook/react/fabric/jni/viewPropConversions.h # ReactCommon/react/renderer/components/view/ViewProps.h # ReactCommon/react/renderer/components/view/primitives.h # ReactCommon/react/renderer/components/view/propsConversions.h # ReactCommon/react/renderer/scheduler/Scheduler.cpp Co-authored-by: Samuel Susla <samuelsusla@fb.com>
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
…ic (microsoft#1634) Due to an early cherry-pick from a more recent facebook/react-native version > microsoft#1498 this broke. In microsoft#1498 I must have only build for rn-iOS + Paper. I think we need a CircleCI job now for rn-iOS + Fabric Here is the fix. - std::optional's function signature is has_value() - where as folly::Optional used hasValue() In packages/rn-tester I ran: ``` USE_FABRIC=1 pod install ``` And then build and launched the app
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
Summary: changelog: Use std::optional instead of butter::optional Reviewed By: fkgozali Differential Revision: D33352680 fbshipit-source-id: 45a53fec181a6ffb6218909bc23348f7c9f21ec4 # Conflicts: # ReactAndroid/src/main/java/com/facebook/react/fabric/jni/viewPropConversions.h # ReactCommon/react/renderer/components/view/ViewProps.h # ReactCommon/react/renderer/components/view/primitives.h # ReactCommon/react/renderer/components/view/propsConversions.h # ReactCommon/react/renderer/scheduler/Scheduler.cpp Co-authored-by: Samuel Susla <samuelsusla@fb.com>
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
…ic (microsoft#1634) Due to an early cherry-pick from a more recent facebook/react-native version > microsoft#1498 this broke. In microsoft#1498 I must have only build for rn-iOS + Paper. I think we need a CircleCI job now for rn-iOS + Fabric Here is the fix. - std::optional's function signature is has_value() - where as folly::Optional used hasValue() In packages/rn-tester I ran: ``` USE_FABRIC=1 pod install ``` And then build and launched the app # Conflicts: # ReactCommon/react/renderer/scheduler/Scheduler.cpp
shwanton
pushed a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
…ic (microsoft#1634) Due to an early cherry-pick from a more recent facebook/react-native version > microsoft#1498 this broke. In microsoft#1498 I must have only build for rn-iOS + Paper. I think we need a CircleCI job now for rn-iOS + Fabric Here is the fix. - std::optional's function signature is has_value() - where as folly::Optional used hasValue() In packages/rn-tester I ran: ``` USE_FABRIC=1 pod install ``` And then build and launched the app # Conflicts: # ReactCommon/react/renderer/scheduler/Scheduler.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
Cherry-pick a react-native@0.69 commit into the current main branch:
facebook@a1594163339
Use std::optional instead of butter::optional
Changelog
changelog: [Internal]
Test Plan
Builds with Fabric (screenshot) and without (CircleCI)