Skip to content

Conversation

christophpurrer
Copy link

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

These changes were 'missed' in #1498

Changelog

[macOS] [Fixed] - Fix C++17 Xcode build when the new architecture is enabled

Test Plan

Build app with Fabric enabled and run it:

yarn
cd packages/rn-tester
bundle install && USE_FABRIC=1 bundle exec pod install
open RNTesterPods.xcworkspace

@christophpurrer christophpurrer marked this pull request as ready for review November 16, 2022 09:26
@christophpurrer christophpurrer requested a review from a team as a code owner November 16, 2022 09:26
@christophpurrer christophpurrer force-pushed the fixXcodeCxx17NewArchBuild branch from 0c971bb to d8f9459 Compare November 16, 2022 09:27
@Saadnajmi Saadnajmi enabled auto-merge (squash) November 16, 2022 14:40
@Saadnajmi Saadnajmi disabled auto-merge November 16, 2022 14:40
@Saadnajmi
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@christophpurrer christophpurrer force-pushed the fixXcodeCxx17NewArchBuild branch from d8f9459 to 36e278f Compare November 16, 2022 17:02
@Saadnajmi Saadnajmi merged commit 3a2426f into microsoft:main Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

2 participants