Fix regression caused by PR 146: 'add normalize/processColorObject.js for ios and macos' #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The recent PR #146 ("add normalize/processColorObject.js for ios and macos") caused a regression. At runtime in ios and macOS a RedBox error saying that processColor is undefined. The reason was because require('processColor') was returning an empty object due to circular dependencies between the new modules normalizeColor, normalizeColorObject, processColor and processColorObject. The fix is to move the require()'s within the functions that need them so that they are executed after the module.exports.
It unclear how PR 146 passed validation. I'm guessing one of the npm dependencies used for packaging changed since the PR impacting the module order.
Microsoft Reviewers: Open in CodeFlow