Skip to content

Conversation

marlenecota
Copy link

@marlenecota marlenecota commented Aug 22, 2019

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Description of changes

Renamed SemanticOrDynamicColorType to NativeOrDynamicColorType.
Split out the logic in processColor.js and normalizeColor.js that deals with handling color objects into their own files (processColorObject.js and normalizeColorObject.js)
Added ios and macos implementation of color object handling.

Microsoft Reviewers: Open in CodeFlow

@marlenecota marlenecota requested a review from tom-un August 22, 2019 20:45
Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • eslint found some issues.
  • flow found some issues.

@pull-bot
Copy link

pull-bot commented Aug 22, 2019

Messages
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

Generated by 🚫 dangerJS against e199a91

@ghost ghost removed the Needs: Author Feedback label Aug 22, 2019
Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • flow found some issues.
  • eslint found some issues.

@ghost ghost removed the Needs: Author Feedback label Aug 22, 2019
Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • flow found some issues.
  • eslint found some issues.

@ghost ghost removed the Needs: Author Feedback label Aug 22, 2019
Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • flow found some issues.

@ghost ghost removed the Needs: Author Feedback label Aug 23, 2019
Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • flow found some issues.

@ghost ghost removed the Needs: Author Feedback label Aug 23, 2019
Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • flow found some issues.

@ghost ghost removed the Needs: Author Feedback label Aug 23, 2019
Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • flow found some issues.

@ghost ghost removed the Needs: Author Feedback label Aug 23, 2019
Copy link

@analysis-bot analysis-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code analysis results:

  • flow found some issues.

@ghost ghost removed the Needs: Author Feedback label Aug 23, 2019
@marlenecota marlenecota requested a review from HeyImChris August 23, 2019 22:31
@ghost ghost removed the Needs: Author Feedback label Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants