[Fabric] Enable NewArchitectureExample Fabric example in RNTester iOS #1520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shwanton
commented
Nov 28, 2022
shwanton
changed the title
4 tasks
Saadnajmi
force-pushed
the
fabric/enable-fabric-example
branch
from
14ff557 to
f1f006f
Compare
Saadnajmi
force-pushed
the
fabric/enable-fabric-example
branch
from
ddf87c5 to
bea1daf
Compare
analysis-bot
suggested changes
Jan 14, 2023
ghost
added
the
Saadnajmi
force-pushed
the
fabric/enable-fabric-example
branch
from
6b03481 to
6fe3bd4
Compare
Saadnajmi
approved these changes
Jan 14, 2023
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
…microsoft#1520) * Enable NewArchitectureExample example in RNTester iOS * Conditionally render MyNativeView * flow-check-ios Co-authored-by: Shawn Dempsey <shawndempsey@fb.com> Co-authored-by: Saad Najmi <sanajmi@microsoft.com>
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
…microsoft#1520) * Enable NewArchitectureExample example in RNTester iOS * Conditionally render MyNativeView * flow-check-ios Co-authored-by: Shawn Dempsey <shawndempsey@fb.com> Co-authored-by: Saad Najmi <sanajmi@microsoft.com> # Conflicts: # packages/rn-tester/Podfile # packages/rn-tester/js/utils/RNTesterList.ios.js
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
…microsoft#1520) * Enable NewArchitectureExample example in RNTester iOS * Conditionally render MyNativeView * flow-check-ios Co-authored-by: Shawn Dempsey <shawndempsey@fb.com> Co-authored-by: Saad Najmi <sanajmi@microsoft.com> # Conflicts: # packages/rn-tester/Podfile # packages/rn-tester/js/utils/RNTesterList.ios.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
While we are implementing Fabric for macOS, we need to ensure that we aren't breaking the Fabric for iOS.
We can ensure the
NativeComponentExamplewill build for Fabric & be accessible on iOS.Once Fabric on macOS is working, this Native Example will not throw an error.
To enable the Native Component, run this during installation
USE_CODEGEN_DISCOVERY=1 USE_FABRIC=1 bundle exec pod install --verboseChangelog
[macOS] [Added] - Enable NewArchitectureExample Fabric example in RNTester iOS
Test Plan
Fabric iOS
CleanShot.2022-11-23.at.16.57.45.mp4
Paper macOS
CleanShot.2022-11-23.at.17.09.03.mp4