Skip to content

Conversation

Saadnajmi
Copy link
Collaborator

@Saadnajmi Saadnajmi commented Jan 14, 2023

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

  • Add a new job to build Fabric iOS on Azure Pipelines. While here, let's also rename the jobs to better reflect what they do
  • Make some Fabric code fixes to get the new Fabric iOS job passing
  • Disable the CircleCI tests that are failing while we are mid 0.71-merge

End result: Green CI checks 🎉

Changelog

[Type] [Added] - Build Fabric iOS on Azure Pipelines

Test Plan

CI passes

@Saadnajmi Saadnajmi requested a review from a team as a code owner January 14, 2023 04:48
@christophpurrer
Copy link

To fix the current linking issue for

2023-01-14T08:17:33.4525870Z     Undefined symbol: _RNTMyNativeViewCls
2023-01-14T08:17:33.4526550Z     Testing cancelled because the build failed.

you should merge in #1520 first from @shwanton

@Saadnajmi Saadnajmi force-pushed the fabric-ci branch 2 times, most recently from 36f711f to 7e8e530 Compare January 14, 2023 22:25
@Saadnajmi Saadnajmi changed the title Build Fabric iOS on Azure Pipelines [CI] Build & Test Fabric iOS, Disable failing CircleCI checks Jan 14, 2023
@Saadnajmi Saadnajmi force-pushed the fabric-ci branch 2 times, most recently from 4fa1eb6 to 63ca60d Compare January 15, 2023 04:10
@Saadnajmi Saadnajmi force-pushed the fabric-ci branch 10 times, most recently from ccc74e0 to 32c5054 Compare January 16, 2023 00:15
@Saadnajmi
Copy link
Collaborator Author

Saadnajmi commented Jan 17, 2023

To fix the current linking issue for

2023-01-14T08:17:33.4525870Z     Undefined symbol: _RNTMyNativeViewCls
2023-01-14T08:17:33.4526550Z     Testing cancelled because the build failed.

you should merge in #1520 first from @shwanton

I still get this error if RCT_NEW_ARCH_ENABLED is set. I spoke offline with @christophpurrer about it, and I'm going to chalk it up to "At this point in time in our repo, the new architecture / codegen are still experimental", and that flag enables more than fabric. I've decided to not set that flag to avoid that error.

@christophpurrer
Copy link

RCT_NEW_ARCH_ENABLED

I think for rn 0.68 you need to set USE_FABRIC ...
The flag RCT_NEW_ARCH_ENABLED wasn't used for Fabric afaik

@Saadnajmi Saadnajmi merged commit c7c7004 into microsoft:main Jan 18, 2023
@Saadnajmi Saadnajmi deleted the fabric-ci branch January 18, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants