Skip to content

Conversation

shwanton
Copy link

@shwanton shwanton commented Dec 1, 2022

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Fabric on macOS implementation:
Disable iOS/Mobile specific api's

  • RCTModalHostViewComponentView
  • UIApplicationDidReceiveMemoryWarningNotification
  • MobileCoreServices/UTCoreTypes

Changelog

[macOS][Fabric] - Disable iOS/Mobile specific api's

Test Plan

[x] Build RNTester-macOS w/ Fabric - builds w/ errors
CleanShot 2022-11-30 at 17 12 16

Build errors:
Build RNTester-macOS_2022-11-30T17-10-39.txt

[x] Build RNTester - iOS w/ Fabric - New architecture example should work
https://user-images.githubusercontent.com/96719/204943642-15f05350-9a28-4a95-8a5e-93f7d4e07c61.mp4

[x] Build RNTester-macOS w/ Paper - should work
CleanShot 2022-11-30 at 17 20 27

[x] Build RNTester - iOS w/ Paper - should work
CleanShot 2022-11-30 at 17 22 11

@shwanton shwanton marked this pull request as ready for review December 1, 2022 01:28
@shwanton shwanton requested a review from a team as a code owner December 1, 2022 01:28
@Saadnajmi Saadnajmi self-assigned this Dec 6, 2022
@Saadnajmi Saadnajmi linked an issue Dec 7, 2022 that may be closed by this pull request
@Saadnajmi Saadnajmi enabled auto-merge (squash) December 7, 2022 01:08
@Saadnajmi Saadnajmi merged commit d8e6216 into microsoft:main Dec 7, 2022
@shwanton shwanton changed the title Fabric/remove ios specific apis [Fabric] Remove ios specific apis Jan 28, 2023
shwanton added a commit to shwanton/react-native-macos that referenced this pull request Feb 13, 2023
* Exclude MobileCoreServices/UTCoreTypes

* Disable UIApplicationDidReceiveMemoryWarningNotification

* Disable RCTModalHostViewComponentView

Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
Co-authored-by: Saad Najmi <sanajmi@microsoft.com>
shwanton added a commit to shwanton/react-native-macos that referenced this pull request Mar 10, 2023
* Exclude MobileCoreServices/UTCoreTypes

* Disable UIApplicationDidReceiveMemoryWarningNotification

* Disable RCTModalHostViewComponentView

Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
Co-authored-by: Saad Najmi <sanajmi@microsoft.com>
# Conflicts:
#	React/Fabric/Mounting/RCTComponentViewRegistry.mm
shwanton added a commit to shwanton/react-native-macos that referenced this pull request Mar 10, 2023
* Exclude MobileCoreServices/UTCoreTypes

* Disable UIApplicationDidReceiveMemoryWarningNotification

* Disable RCTModalHostViewComponentView

Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
Co-authored-by: Saad Najmi <sanajmi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exclude UTCoreTypes.h

3 participants