[Fabric] Fix unterminated conditional that was breaking Fabric iOS build #1574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
approved these changes
Dec 7, 2022
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Feb 13, 2023
Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
shwanton
added a commit
to shwanton/react-native-macos
that referenced
this pull request
Mar 10, 2023
Co-authored-by: Shawn Dempsey <shawndempsey@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
#1533 Added a unterminated conditional that I didn't catch during my testing.
For testing, I build Paper first, then Fabric but for this run I swapped the order.
NOTE: This might be a good reminder that we should setup a CI job to build Fabric for iOS
Changelog
[FIX] [MacOS] - Fix unterminated conditional that was breaking Fabric iOS build
Test Plan
Build w/ Fabric
https://user-images.githubusercontent.com/96719/206294852-ee6c39b6-ac92-418d-b156-1c035e9e7394.mp4
Build w/ Paper
https://user-images.githubusercontent.com/96719/206295953-af6af4a1-ba23-4011-b4e6-da3a1190a8a1.mp4